(Request) Refactor Building_AutoMachineTool.cs

[Sn1p3rr3c0n]

https://github.com/zymex22/Project-RimFactory-Revived/blob/master/Source/ProjectRimFactory/AutoMachineTool/Building_AutoMachineTool.cs
is a bit messy and should get Refactored.

With a96dc09 I attempted this but I broke Reservations and Saving in the process.

#506 will be resolved with #528.
This new issue shall be used for Refactoring the File / Class

[Sn1p3rr3c0n]

The following save related issues remain in d0445c2

SaveableFromNode exception: System.MissingMethodException: Constructor on type 'ProjectRimFactory.AutoMachineTool.SAL_TargetWorktable' not found.
  at System.RuntimeType.CreateInstanceImpl (System.Reflection.BindingFlags bindingAttr, System.Reflection.Binder binder, System.Object[] args, System.Globalization.CultureInfo culture, System.Object[] activationAttributes, System.Threading.StackCrawlMark& stackMark) [0x00213] in <eae584ce26bc40229c1b1aa476bfa589>:0 
  at System.Activator.CreateInstance (System.Type type, System.Reflection.BindingFlags bindingAttr, System.Reflection.Binder binder, System.Object[] args, System.Globalization.CultureInfo culture, System.Object[] activationAttributes) [0x00095] in <eae584ce26bc40229c1b1aa476bfa589>:0 
  at System.Activator.CreateInstance (System.Type type, System.Object[] args) [0x00000] in <eae584ce26bc40229c1b1aa476bfa589>:0 
  at Verse.ScribeExtractor.SaveableFromNode[T] (System.Xml.XmlNode subNode, System.Object[] ctorArgs) [0x0012f] in <360933dd75ad47e8a6d2a631ae77b5d8>:0 
Subnode:
<salTarget Class="ProjectRimFactory.AutoMachineTool.SAL_TargetWorktable"><unfinished IsNull="True" /><bill>null</bill><dominant>null</dominant><ingredients IsNull="True" /></salTarget> 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39)

SaveableFromNode exception: System.MissingMethodException: Constructor on type 'ProjectRimFactory.AutoMachineTool.SAL_TargetResearch' not found.
  at System.RuntimeType.CreateInstanceImpl (System.Reflection.BindingFlags bindingAttr, System.Reflection.Binder binder, System.Object[] args, System.Globalization.CultureInfo culture, System.Object[] activationAttributes, System.Threading.StackCrawlMark& stackMark) [0x00213] in <eae584ce26bc40229c1b1aa476bfa589>:0 
  at System.Activator.CreateInstance (System.Type type, System.Reflection.BindingFlags bindingAttr, System.Reflection.Binder binder, System.Object[] args, System.Globalization.CultureInfo culture, System.Object[] activationAttributes) [0x00095] in <eae584ce26bc40229c1b1aa476bfa589>:0 
  at System.Activator.CreateInstance (System.Type type, System.Object[] args) [0x00000] in <eae584ce26bc40229c1b1aa476bfa589>:0 
  at Verse.ScribeExtractor.SaveableFromNode[T] (System.Xml.XmlNode subNode, System.Object[] ctorArgs) [0x0012f] in <360933dd75ad47e8a6d2a631ae77b5d8>:0 
Subnode:
<salTarget Class="ProjectRimFactory.AutoMachineTool.SAL_TargetResearch" /> 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39)

SaveableFromNode exception: System.MissingMethodException: Constructor on type 'ProjectRimFactory.AutoMachineTool.SAL_TargetDeepDrill' not found.
  at System.RuntimeType.CreateInstanceImpl (System.Reflection.BindingFlags bindingAttr, System.Reflection.Binder binder, System.Object[] args, System.Globalization.CultureInfo culture, System.Object[] activationAttributes, System.Threading.StackCrawlMark& stackMark) [0x00213] in <eae584ce26bc40229c1b1aa476bfa589>:0 
  at System.Activator.CreateInstance (System.Type type, System.Reflection.BindingFlags bindingAttr, System.Reflection.Binder binder, System.Object[] args, System.Globalization.CultureInfo culture, System.Object[] activationAttributes) [0x00095] in <eae584ce26bc40229c1b1aa476bfa589>:0 
  at System.Activator.CreateInstance (System.Type type, System.Object[] args) [0x00000] in <eae584ce26bc40229c1b1aa476bfa589>:0 
  at Verse.ScribeExtractor.SaveableFromNode[T] (System.Xml.XmlNode subNode, System.Object[] ctorArgs) [0x0012f] in <360933dd75ad47e8a6d2a631ae77b5d8>:0 
Subnode:
<salTarget Class="ProjectRimFactory.AutoMachineTool.SAL_TargetDeepDrill" /> 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39)

Could not resolve reference to object with loadID Thing_Human33801 of type Verse.Pawn. Was it compressed away, destroyed, had no ID number, or not saved/loaded right? curParent=null:null, null, null, 1, -1 curPathRelToParent= 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39)

Could not resolve reference to object with loadID Job_857 of type Verse.AI.Job. Was it compressed away, destroyed, had no ID number, or not saved/loaded right? curParent=null:null, null, null, 1, -1 curPathRelToParent= 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39)

Could not resolve reference to object with loadID Thing_Human33801 of type Verse.Pawn. Was it compressed away, destroyed, had no ID number, or not saved/loaded right? curParent=null:null, null, null, 1, -1 curPathRelToParent= 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39)

Could not resolve reference to object with loadID Job_857 of type Verse.AI.Job. Was it compressed away, destroyed, had no ID number, or not saved/loaded right? curParent=null:null, null, null, 1, -1 curPathRelToParent= 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39)

Loaded reservation with null claimant: null:null, Thing_DeepDrill18113, null, 1, -1. Deleting it... 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39)

Loaded reservation with null job: null:null, Thing_DeepDrill18113, null, 1, -1. Deleting it... 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39)

Loaded reservation with null claimant: null:null, Thing_HiTechResearchBench18111, null, 1, -1. Deleting it... 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39)

Loaded reservation with null job: null:null, Thing_HiTechResearchBench18111, null, 1, -1. Deleting it... 
(Filename: C:\buildslave\unity\build\Runtime/Export/Debug/Debug.bindings.h Line: 39)

[Sn1p3rr3c0n]

Currently the last remaining known issue is that,
when loading a save from a previous version where the SAL is actively working on a bill

• The bill progress will be lost
• that SAL needs to be rebuild

this issue might be fixable using PostExposeData(object obj) of the BackCompatibilityConverter