Remove empty rules in regions #3458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaluka
reviewed
Sep 8, 2024
This allows us to remove the empty "rules: []" in various syntax definitions.
Co-authored-by: Dmytro Maluka <[email protected]>
JoeKar
force-pushed
the
feature/empty-rules
branch
from
51e0117
to
596da97
Compare
dmaluka
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It had been bothering me for some time that we have to add empty
rulesto theregionsdefined in thesyntaxdefinitions in case no further nesting shall apply (rules: []).This came up in #3450 again and I decide to take care of it.