Fix lost mouse release events in case the pane becomes inactive #3271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaluka
reviewed
Apr 26, 2024
JoeKar
force-pushed
the
fix/inactive-mouse-release
branch
from
095aee2 to
1313d39
Compare
dmaluka
reviewed
Apr 27, 2024
| case tcell.ButtonNone: | ||
| if t.List[t.Active()].release { | ||
| // Mouse release received, while already released...reset mouse | ||
| t.ResetMouse() |
There was a problem hiding this comment.
I guess we can return here?
There was a problem hiding this comment.
Yep, we can. the ButtonNone event in the Tab's HandleEvent does what it needs to do in case the release was for the active Tab.
So I will add the return.
JoeKar
force-pushed
the
fix/inactive-mouse-release
branch
from
1313d39 to
0a1447b
Compare
dmaluka
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first shot to fix the mouse releases received in a different pane/tab, while the one pressed still waits for his release.
Fixes #3251