colorscheme: Add capability to include schemes #2844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeKar
force-pushed
the
feature/colorscheme-include
branch
from
5dd4b24
to
6f232e5
Compare
|
Great, I fully support it. It is also can be useful for plugin developer. I have been already thought about custom color scheme but it was just <ctrl+c, ctrl+v, change several lines> so I decided not to add it to the plugin... |
JoeKar
force-pushed
the
feature/colorscheme-include
branch
from
6f232e5
to
03387c2
Compare
dmaluka
reviewed
Mar 16, 2024
JoeKar
force-pushed
the
feature/colorscheme-include
branch
2 times, most recently
from
c42520b
to
06e1d01
Compare
dmaluka
reviewed
Mar 18, 2024
JoeKar
force-pushed
the
feature/colorscheme-include
branch
3 times, most recently
from
7c33eee
to
1ff5d8f
Compare
dmaluka
reviewed
Mar 19, 2024
JoeKar
force-pushed
the
feature/colorscheme-include
branch
from
1ff5d8f
to
b79f7ad
Compare
dmaluka
reviewed
Mar 20, 2024
JoeKar
force-pushed
the
feature/colorscheme-include
branch
from
b79f7ad
to
8347906
Compare
dmaluka
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was already wondering, why the default color scheme
default.microfile tries to track the same content as the as default definedmonokai.micro. This becomes even worse when I had a look into the diff of both files:Since this causes duplicated maintenance effort and is error prone I decide to change the approach.
The easiest way would be to use symbolic links, but they aren't supported by the embed.FS, which is most probably the reason for the duplication of the content. With the introduction of the
includesupport in the color schemes the same result can be achieved. Additionally it's still a reduction of space used within the binary, the maintenance effort decreases, already existing schemes can be extended/slightly adapted and the default theme can be changed by changing the name of the included scheme only.