Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolved browser entrypoint issue #52

Merged
merged 1 commit into from
Apr 10, 2021

Conversation

odahcam
Copy link
Member

@odahcam odahcam commented Apr 9, 2021

The old browser entry point was causing some confusion to module bundlers which didn't prefer bundling from the actual module entry point. The old browser entry point was removed since all entrypoint are meant to work on browsers and so on the bundlers can make better choices.

A unpkg entry point was added since UNPKG makes a big part in the usage of this lib.

Reference content about package.json entry points:


Many thanks to Timly for sponsoring this PR. 💙🐇

@odahcam odahcam changed the base branch from master to release/v0.0.9 April 9, 2021 18:22
@fydelio
Copy link

fydelio commented Apr 10, 2021

Hey @odahcam

Many thx for making a push on this topic and we from Timly are happy to sponsor this PR and in general your work.
FYI: This solution will solve the issue reported here: #37. @cis-deepesh was working with me on the exact this "reported" problem.

Philipp

@odahcam odahcam merged commit cdb99ee into release/v0.0.9 Apr 10, 2021
@odahcam odahcam deleted the bugfix/package-entrypoitns branch April 10, 2021 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants