Update splitter.rb #71
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed Issue of exceeding selectors. The problem with the ranges is, that if the first rule that contributes to a range has more than 1 selector, the total amount of selectors in that range will exceed the limit. For example: lets say we want to get the second split with the range [4096..8191]. In the current implementation, if there is a rule with 100 selectors that starts at selector index 4000, it will be part of the current split (because 4000 + 100 = 4100, which lies inside the range [4096..8191]). As a result the limit in this range could be exceeded by up to 95 selectors (especially if there are no selectors truncated at the end of the range). I therefor propose a rolling window.
Contributor
|
thanks for finding that bug and fixing it right away. 👍 could you please add a regression test case to your PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issue of exceeding selectors.
The problem with the ranges is, that if the first rule that contributes to a range has more than 1 selector, the total amount of selectors in that range will exceed the limit.
For example: lets say we want to get the second split with the range [4096..8191]. In the current implementation, if there is a rule with 100 selectors that starts at selector index 4000, it will be part of the current split (because 4000 + 100 = 4100, which lies inside the range [4096..8191]). As a result the limit in this range could be exceeded by up to 95 selectors (especially if there are no selectors truncated at the end of the range). I therefor propose a rolling window.