unifykey: check return value of of_property_read_u32

PD#150092: Calling "of_property_read_u32" without checking return value driver defect clean up: torvalds#30 Change-Id: I590627fec489e2251c689b9a013d5c792ff19975 Signed-off-by: Jiamin Ma <[email protected]>
zuma-array · Nov 4, 2022 · d765b50 · d765b50
1 parent f1edd29
commit d765b50
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/drivers/amlogic/unifykey/unifykey_dts.c b/drivers/amlogic/unifykey/unifykey_dts.c
@@ -287,10 +287,13 @@ int unifykey_dt_create(struct platform_device *pdev)
 			__LINE__);
 		return ret;
 	}
-	/* set default efuse version info */
-	unify_key_info.efuse_version = -1;
-	of_property_read_u32(pdev->dev.of_node, "efuse-version",
+
+	ret = of_property_read_u32(pdev->dev.of_node, "efuse-version",
 		&unify_key_info.efuse_version);
+	if (ret != 0) {
+		pr_info("no efuse-version set, use default value: -1\n");
+		unify_key_info.efuse_version = -1;
+	}
 
 	pr_info("key unify config unifykey-num is %d\n", key_num);
 	unify_key_info.key_num = key_num;