WIP: Support displaying of images in msg in the default viewer. #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanagr
commented
May 22, 2019
| @@ -347,3 +350,37 @@ def match_user(user: Any, text: str) -> bool: | |||
| if keyword.startswith(text.lower()): | |||
| return True | |||
| return False | |||
|
|
|||
|
|
|||
| # Plan to open all the images/gifs in a msg | |||
There was a problem hiding this comment.
@neiljp I have mentioned the plan here. Please go through it.
shreyamalviya
added a commit
to shreyamalviya/zulip-terminal
that referenced
this pull request
Jul 17, 2019
shreyamalviya
added a commit
to shreyamalviya/zulip-terminal
that referenced
this pull request
Jul 17, 2019
Pressing enter on one of the buttons in links popup menu does one of the following, depending on the link: - narrow to stream - narrow to user - open image in system's default viewer - open link in system's default browser Narrows to stream/user and opens images Narrows to stream/user successfuly. Opens selected image in default viewer. Gives 401 error while trying to open gifs or videos. Opens links in default browser Opens links in default browser (code from zulip#397). Tries to download and open user uploaded media in default system viewer (code from zulip#359), otherwise opens link in default browser. Opens images/gifs/links in default system viewer To fix: Issue with videos
shreyamalviya
added a commit
to shreyamalviya/zulip-terminal
that referenced
this pull request
Jul 31, 2019
Pressing enter on one of the buttons in links popup menu does one of the following, depending on the link: - narrow to stream - narrow to user - open image in system's default viewer - open link in system's default browser Narrows to stream/user and opens images Narrows to stream/user successfuly. Opens selected image in default viewer. Gives 401 error while trying to open gifs or videos. Opens links in default browser Opens links in default browser (code from zulip#397). Tries to download and open user uploaded media in default system viewer (code from zulip#359), otherwise opens link in default browser. Opens images/gifs/links in default system viewer Opens videos in default viewer
12 tasks
|
Heads up @amanagr, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
|
The followup to this was merged with slight adjustments in #1223 🎉 Thanks @amanagr, @preetmishra and @Ezio-Sarthak 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.