Skip to content

Conversation

@chrisbobbe
Copy link
Contributor

The retired repo "jcenter" has been saying for years that it'll go away, and that seems to have happened. Take this dependency at a later version, which is available from Maven Central.

Fixes: #5888

The retired repo "jcenter" has been saying for years that it'll go
away, and that seems to have happened. Take this dependency at a
later version, which is available from Maven Central.

Fixes: zulip#5888
@chrisbobbe chrisbobbe added P0 critical Highest priority dependencies Pull requests that update a dependency file labels Sep 18, 2024
@chrisbobbe chrisbobbe requested a review from gnprice September 18, 2024 23:46
@chrisbobbe
Copy link
Contributor Author

Tested on the office Android device (Samsung Galaxy S9 running Android 9). Not sure if this needs testing on a newer Android.

@gnprice
Copy link
Member

gnprice commented Sep 19, 2024

Thanks! Looks good — merging.

I think this shouldn't interact much with the Android version.

I did try running it… but found our shell.nix has bitrotted somewhat so that nix-shell --run tools/android (and indeed nix-shell --run adb) doesn't work on the NixOS version I now have on my office desktop. So I won't spend time trying to resolve that right now, for this legacy codebase. (My home desktop still works fine, when I'm at home.)

@gnprice gnprice merged commit 1485d82 into zulip:main Sep 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file P0 critical Highest priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android build fails, at me.relex:photodraweeview

2 participants