Skip to content

TranslationProvider: Fix crash on login, from non-null-FL invariant #5865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2024
Merged

TranslationProvider: Fix crash on login, from non-null-FL invariant #5865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/boot/TranslationProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import {
streamChannelRenameFeatureLevel,
streamChannelRenamesMap,
} from './streamChannelRenamesMap';
import { getHaveServerData } from '../haveServerDataSelectors';

// $FlowFixMe[incompatible-type] could put a well-typed mock value here, to help write tests
export const TranslationContext: React.Context<GetText> = React.createContext(undefined);
Expand Down Expand Up @@ -103,6 +104,7 @@ export default function TranslationProvider(props: Props): React.Node {
// TODO(server-9.0) remove "stream" terminology
const effectiveMessagesByLanguage =
activeAccountState == null
|| !getHaveServerData(activeAccountState)
|| getZulipFeatureLevel(activeAccountState) >= streamChannelRenameFeatureLevel
? messagesByLanguageRenamed
: messagesByLanguage;
Expand Down
5 changes: 3 additions & 2 deletions src/boot/streamChannelRenamesMap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,9 @@
* The feature level at which we want to say "channel" instead of "stream".
*
* Outside a per-account context, check the feature level of the active
* account, if there is one. If there isn't an active account, just choose
* "channel" terminology unconditionally.
* account, if there is one and it has server data. If there isn't an active
* account or it doesn't have server data, just choose "channel" terminology
* unconditionally.
*/
// TODO(server-9.0) simplify away
// https://chat.zulip.org/api/changelog#changes-in-zulip-90
Expand Down