-
-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compose: Allow image multi-selection, where supported #5638
Conversation
We recently completed the feature of not immediately sending messages with image uploads, in zulip#5474. With that, it became possible to send a message with multiple uploaded images in it. But you had to go through the image-selection flow once for each of your chosen images; see discussion: zulip#5474 (review) This gives a smoother experience by letting you choose multiple images in one image-selection session. Related: zulip#2366 Co-authored-by: Akash Dhiman <[email protected]>
Android pre-13 behavior is unchanged. Android 13 before / after: Note that the "before" UI was new in fc2dab7, released in the v27.198 beta. That was an unplanned UI change for Android 13+, due to a change in the |
8f8873f
to
32f3fc9
Compare
Thanks! Looks good; merging.
Yeah. I guess we should add that to the changelog under v27.198. |
We discovered this while working on #5638, "compose: Allow image multi-selection, where supported".
Thanks for the review!
Done: e4d162c |
Planned followup to #5474.
We recently completed the feature of not immediately sending
messages with image uploads, in #5474. With that, it became possible
to send a message with multiple uploaded images in it. But you had
to go through the image-selection flow once for each of your chosen
images; see discussion:
#5474 (review)
This gives a smoother experience by letting you choose multiple
images in one image-selection session.
Related: #2366
Co-authored-by: Akash Dhiman [email protected]
cc @alya for the UX change