Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compose: Allow image multi-selection, where supported #5638

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

chrisbobbe
Copy link
Contributor

@chrisbobbe chrisbobbe commented Jan 12, 2023

Planned followup to #5474.


We recently completed the feature of not immediately sending
messages with image uploads, in #5474. With that, it became possible
to send a message with multiple uploaded images in it. But you had
to go through the image-selection flow once for each of your chosen
images; see discussion:
#5474 (review)

This gives a smoother experience by letting you choose multiple
images in one image-selection session.

Related: #2366
Co-authored-by: Akash Dhiman [email protected]


cc @alya for the UX change

@chrisbobbe chrisbobbe added the a-compose/send Compose box, autocomplete, camera/upload, outbox, sending label Jan 12, 2023
@chrisbobbe
Copy link
Contributor Author

iOS before / after:

We recently completed the feature of not immediately sending
messages with image uploads, in zulip#5474. With that, it became possible
to send a message with multiple uploaded images in it. But you had
to go through the image-selection flow once for each of your chosen
images; see discussion:
  zulip#5474 (review)

This gives a smoother experience by letting you choose multiple
images in one image-selection session.

Related: zulip#2366
Co-authored-by: Akash Dhiman <[email protected]>
@chrisbobbe
Copy link
Contributor Author

Android pre-13 behavior is unchanged.

Android 13 before / after:

Note that the "before" UI was new in fc2dab7, released in the v27.198 beta. That was an unplanned UI change for Android 13+, due to a change in the react-native-image-picker library we use. But Greg, who uses Android regularly, says it's an improvement over what we were offering before.

@gnprice
Copy link
Member

gnprice commented Jan 12, 2023

Thanks! Looks good; merging.

Note that the "before" UI was new in fc2dab7, released in the v27.198 beta. That was an unplanned UI change for Android 13+, due to a change in the react-native-image-picker library we use. But Greg, who uses Android regularly, says it's an improvement over what we were offering before.

Yeah. I guess we should add that to the changelog under v27.198.

@gnprice gnprice merged commit 32f3fc9 into zulip:main Jan 12, 2023
@chrisbobbe chrisbobbe deleted the pr-multi-image-select branch January 12, 2023 23:26
chrisbobbe added a commit that referenced this pull request Jan 12, 2023
We discovered this while working on #5638, "compose: Allow image
multi-selection, where supported".
@chrisbobbe
Copy link
Contributor Author

Thanks for the review!

I guess we should add that to the changelog under v27.198.

Done: e4d162c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-compose/send Compose box, autocomplete, camera/upload, outbox, sending
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants