action-sheets: Use navigation object instead of NavigationService
#5560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etc.) This way, we can stop using NavigationService in these action sheets, and instead use `navigation.push` calls. React Navigation upstream recommends avoiding the NavigationService approach where possible, and this goes in that direction; see more in zulip#5408.
Further in the direction of zulip#5408, which switched most of our then-existing uses of NavigationService to use `navigation` instead. As noted there: > Switching away from `NavigationService` is recommended by React > Navigation upstream, as described at zulip#4417. We also now get > type-checking on those `navigation.push` calls -- Flow is able to > check that the route params we pass line up with what the route in > question expects -- which wasn't/isn't the case for the > implementations of the `navActions` functions. This causes a few of the navActions functions to lose their last remaining caller, so delete those.
chrisbobbe
force-pushed
the
pr-action-sheets-navigation-object
branch
from
e10c313 to
39c903c
Compare
Further in the direction of zulip#5408, which switched most of our then-existing uses of NavigationService to use `navigation` instead. As noted there: > Switching away from `NavigationService` is recommended by React > Navigation upstream, as described at zulip#4417. We also now get > type-checking on those `navigation.push` calls -- Flow is able to > check that the route params we pass line up with what the route in > question expects -- which wasn't/isn't the case for the > implementations of the `navActions` functions. This causes a few of the navActions functions to lose their last remaining caller, so delete those.
chrisbobbe
force-pushed
the
pr-action-sheets-navigation-object
branch
from
39c903c to
a622636
Compare
Contributor
Author
|
Just added two commits that remove |
Member
|
Thanks for this cleanup! Looks great -- merging. |
Contributor
Author
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I plucked this small PR from some work I did while dealing with #5489 but that didn't make it into #5489.)