action-sheets types: Make Button's title/errorMessage LocalizableText #5559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already have comments saying the strings are UI strings that should be represented in messages_en.json. But this reinforces the point, and also lets you pass the kind of LocalizableText that is an object with `.text` and `.values`.
Member
|
Thanks! Looks good; merging, with a small punctuation/formatting fix in the commit message. |
gnprice
force-pushed
the
pr-action-sheet-button-localizable-text
branch
from
27ddbc7 to
04d47b8
Compare
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have comments saying the strings are UI strings that should be represented in messages_en.json. But this reinforces the point, and also lets you pass the kind of LocalizableText that is an object with
.text and.values`.(I plucked this tiny PR from some work I did while dealing with #5489 but that didn't make it into #5489.)