android: Fix build to get react-native only from local Maven repo#5535
Merged
gnprice merged 1 commit intozulip:mainfrom Nov 5, 2022
Merged
android: Fix build to get react-native only from local Maven repo#5535gnprice merged 1 commit intozulip:mainfrom
gnprice merged 1 commit intozulip:mainfrom
Conversation
This fixes a build failure which started happening today due to an operational mistake in React Native release management: facebook/react-native#35204 Happily Gradle gives us a way to more precisely pin down what we want it to do when finding dependencies, which makes the build robust to this and any similar issue. I've sent the same fix upstream for the template app: facebook/react-native#35208 See also where we spotted the issue in CI: zulip#5524 (comment) and discussion in chat: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/build.20failure.3A.20libfbjni.2Eso.20duplicated/near/1459787
Contributor
|
Great, thanks, LGTM! Please merge at will. |
Closed
BrandonNgoranNtam
pushed a commit
to BrandonNgoranNtam/zulip-mobile
that referenced
this pull request
Nov 22, 2022
When we upgrade to RN v0.71 (the version that's now approaching release), we'll no longer need this code we modified recently in 117e548 / zulip#5535. Add a note to help us remove it then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a build failure which started happening today due to an operational mistake in React Native release management:
facebook/react-native#35204
Happily Gradle gives us a way to more precisely pin down what we want it to do when finding dependencies, which makes the build robust to this and any similar issue. I've sent the same fix upstream for the template app:
facebook/react-native#35208
See also where we spotted the issue in CI:
#5524 (comment)
and discussion in chat:
https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/build.20failure.3A.20libfbjni.2Eso.20duplicated/near/1459787