ios notif [nfc]: Simplify out some redundant logic#5252
Merged
gnprice merged 2 commits intozulip:mainfrom Feb 19, 2022
Merged
Conversation
gnprice
changed the title
Contributor
|
Great! LGTM; please merge at will. |
It's true that another iOS notifications library might have a different interface in this respect. But if someday in the future we switch to a different iOS notifications library with a different interface, we'll be updating this code for the new set of expectations in any case -- there's no gain from attempting to accommodate in today's code one of the many possible ways the interface could differ. Moreover, as far as this particular point of the interface is concerned… none of the subsequent code actually notices or cares whether there's an `aps` property on the object. It takes the `zulip` property, and does nothing with the rest of the object. So going and removing an `aps` property first has no meaningful effect.
gnprice
force-pushed
the
pr-notif-extract
branch
from
281f554 to
5a14868
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's true that another iOS notifications library might have a
different interface in this respect. But if someday in the future we
switch to a different iOS notifications library with a different
interface, we'll be updating this code for the new set of expectations
in any case -- there's no gain from attempting to accommodate in
today's code one of the many possible ways the interface could differ.
Moreover, as far as this particular point of the interface is
concerned… none of the subsequent code actually notices or cares
whether there's an
apsproperty on the object. It takes thezulipproperty, and does nothing with the rest of the object. So going and
removing an
apsproperty first has no meaningful effect.