Revert "webview html: Get stream name from stream, rather than message"#5207
Merged
chrisbobbe merged 1 commit intozulip:mainfrom Jan 28, 2022
Merged
Revert "webview html: Get stream name from stream, rather than message"#5207chrisbobbe merged 1 commit intozulip:mainfrom
chrisbobbe merged 1 commit intozulip:mainfrom
Conversation
gnprice
added
api migrations
P1 high-priority
severe: crash
This was referenced Jan 28, 2022
This reverts most of commit 9d05bba. We leave the test changes in place, because those just set up better fixture data. It's possible for the message list to show messages in streams that we don't actually have data for: in particular, streams that our user was previously a member of (and received some messages there while they were), but no longer is, and can't see (because it's private and they're not an admin, or because they're a guest.) As a result, we can't simply get the stream name here from our streams data. There are a couple of ways we could go to fix the issue that commit originally fixed, so that recipient headers get updated when a stream is renamed; I'll discuss those in or linked from the issue zulip#5206. In the meantime, revert, because a crash when you've left the stream is a lot worse than an out-of-date name when it's been renamed. Fixes: zulip#5206
chrisbobbe
force-pushed
the
pr-stream-name
branch
from
b286db6 to
57c914a
Compare
Contributor
|
Ah, well. Merged, thanks! And thanks for filing #5208. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts most of commit 9d05bba (from #5183).
We leave the test changes in place, because those just set up better
fixture data.
It's possible for the message list to show messages in streams that
we don't actually have data for: in particular, streams that our user
was previously a member of (and received some messages there while
they were), but no longer is, and can't see (because it's private and
they're not an admin, or because they're a guest.) As a result, we
can't simply get the stream name here from our streams data.
There are a couple of ways we could go to fix the issue that commit
originally fixed, so that recipient headers get updated when a stream
is renamed; I'll discuss those in or linked from the issue #5206.
In the meantime, revert, because a crash when you've left the stream
is a lot worse than an out-of-date name when it's been renamed.
Fixes: #5206