narrow: Store stream IDs instead of names!#5205

Merged

chrisbobbe merged 24 commits into

zulip:mainfrom

gnprice:pr-streamid-narrow

Feb 1, 2022

Commits on Jan 28, 2022

lint: Disable no-control-regex
gnprice
committed
notif [nfc]: Say `stream_name` for a stream name, vs just `stream`
gnprice
committed
notif: Find stream on opening a stream-message notification
gnprice
committed
drafts tests: Type-check draftsReducer-test.js
gnprice
committed
stream [nfc]: Delete redundant, inefficient getSubscribedStreams
gnprice
committed
subscriptions tests: Well-type, using exampleData
gnprice
committed
tests [nfc]: Use more whole streams rather than names
gnprice
committed
narrow [nfc]: Accept optional stream ID in Narrow constructors
gnprice
committed
narrow [nfc]: Pass stream IDs to Narrow constructors, almost everywhere
gnprice
committed
narrow: Store stream IDs, not only names!
gnprice
committed
nav: Omit "topic list", "stream info" buttons on unknown streams
gnprice
committed
narrow: Cut all unneeded calls to streamNameOfNarrow
gnprice
committed
subscriptions [nfc]: Cut now-disused getSubscriptionsByName
gnprice
committed
webview [nfc]: Cut streamsByName from BackgroundData
gnprice
committed
narrow [nfc]: Drop unused parameters at some caseNarrow call sites
gnprice
committed
narrow: Switch to stream ID at some caseNarrow call sites
gnprice
committed
narrow: Use stream ID in getComposeInputPlaceholder
gnprice
committed
narrow: Use narrow's stream ID to get name in apiNarrowOfNarrow
gnprice
committed
narrow: Stop storing stream names!
gnprice
committed
narrow [nfc]: Drop stream names from caseNarrow callbacks
gnprice
committed
narrow [nfc]: Delete now-vacuous streamNameOfNarrow
gnprice
committed
narrow [nfc]: Stop taking stream name in constructors
gnprice
committed
internal links [nfc]: Return whole Stream from parseStreamOperand
gnprice
committed
stream [nfc]: Drop a few more stream names, after ID-only narrows
gnprice
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

narrow: Store stream IDs instead of names!#5205

narrow: Store stream IDs instead of names!#5205
chrisbobbe merged 24 commits into
zulip:mainfrom
gnprice:pr-streamid-narrow

Commits on Jan 28, 2022

lint: Disable no-control-regex

notif [nfc]: Say `stream_name` for a stream name, vs just `stream`

notif: Find stream on opening a stream-message notification

drafts tests: Type-check draftsReducer-test.js

stream [nfc]: Delete redundant, inefficient getSubscribedStreams

subscriptions tests: Well-type, using exampleData

tests [nfc]: Use more whole streams rather than names

narrow [nfc]: Accept optional stream ID in Narrow constructors

narrow [nfc]: Pass stream IDs to Narrow constructors, almost everywhere

narrow: Store stream IDs, not only names!

nav: Omit "topic list", "stream info" buttons on unknown streams

narrow: Cut all unneeded calls to streamNameOfNarrow

subscriptions [nfc]: Cut now-disused getSubscriptionsByName

webview [nfc]: Cut streamsByName from BackgroundData

narrow [nfc]: Drop unused parameters at some caseNarrow call sites

narrow: Switch to stream ID at some caseNarrow call sites

narrow: Use stream ID in getComposeInputPlaceholder

narrow: Use narrow's stream ID to get name in apiNarrowOfNarrow

narrow: Stop storing stream names!

narrow [nfc]: Drop stream names from caseNarrow callbacks

narrow [nfc]: Delete now-vacuous streamNameOfNarrow

narrow [nfc]: Stop taking stream name in constructors

internal links [nfc]: Return whole Stream from parseStreamOperand

stream [nfc]: Drop a few more stream names, after ID-only narrows