ZulipAsyncStorage types [nfc]: Add a quick annotation, for types-first.#4976
Merged
gnprice merged 1 commit intozulip:masterfrom Sep 1, 2021
Merged
Conversation
Contributor
Author
|
(#4947 was an earlier approach to this.) |
gnprice
force-pushed
the
pr-annotate-zulip-async-storage
branch
from
d5e54ce to
f049aa8
Compare
Member
|
Thanks, looks good -- merging! I went and merged #4974 first, as it sounds like this should be sequenced after that 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The in-progress PR #4974 can help verify that these annotations are appropriate.
Related: #4907