Annotate most exported connected components.#4943
Merged
chrisbobbe merged 22 commits intozulip:masterfrom Aug 10, 2021
Merged
Conversation
Merged
gnprice
reviewed
Aug 10, 2021
Member
gnprice
left a comment
gnprice
left a comment
There was a problem hiding this comment.
Thanks @chrisbobbe! All looks good, with one nit below; then please merge at will.
Comment on lines
+85
to
+94
| type Props = $ReadOnly<{| | ||
| ...OuterProps, | ||
|
|
||
| // from withSafeAreaInsets | ||
| insets: EdgeInsets, | ||
|
|
||
| // from `connect` |
Member
There was a problem hiding this comment.
nit: Let's put these (and the prop from withGetText, below) in a consistent order relative to how we do the wrapping, so it's easy to compare the two and see that they line up.
In the common case with just connect, we generally put those at the end, so I guess let's do it consistent with that: OuterProps first, then the next thing inward (which is withGetText), then the next thing inward, etc.
We should eventually convert this to a function component for zulip#4837. In the meantime, this annotation will get us closer to switching to Flow's new "Types-First" mode; that's zulip#4907.
Like we currently do in `MessageList`, where the set of props that callers are meant to pass gets a bit opaque from the use of several HOCs. See https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/Flow.20types-first/near/1243407.
We should eventually convert this to a function component for zulip#4837. In the meantime, this annotation will get us closer to switching to Flow's new "Types-First" mode; that's zulip#4907.
We should eventually convert this to a function component for zulip#4837. In the meantime, this annotation will get us closer to switching to Flow's new "Types-First" mode; that's zulip#4907.
We should eventually convert this to a function component for zulip#4837. In the meantime, this annotation will get us closer to switching to Flow's new "Types-First" mode; that's zulip#4907.
We should eventually convert this to a function component for zulip#4837. In the meantime, this annotation will get us closer to switching to Flow's new "Types-First" mode; that's zulip#4907.
We should eventually convert this to a function component for zulip#4837. In the meantime, this annotation will get us closer to switching to Flow's new "Types-First" mode; that's zulip#4907.
We should eventually convert this to a function component for zulip#4837. In the meantime, this annotation will get us closer to switching to Flow's new "Types-First" mode; that's zulip#4907.
We should eventually convert this to a function component for zulip#4837. In the meantime, this annotation will get us closer to switching to Flow's new "Types-First" mode; that's zulip#4907.
We should eventually convert this to a function component for zulip#4837. In the meantime, this annotation will get us closer to switching to Flow's new "Types-First" mode; that's zulip#4907.
We should eventually convert this to a function component for zulip#4837. In the meantime, this annotation will get us closer to switching to Flow's new "Types-First" mode; that's zulip#4907.
We should eventually convert this to a function component for zulip#4837. In the meantime, this annotation will get us closer to switching to Flow's new "Types-First" mode; that's zulip#4907.
chrisbobbe
force-pushed
the
pr-annotate-connected-components
branch
from
e4581c3 to
1990c46
Compare
Contributor
Author
|
Thanks for the review! Merged, with that tweak. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the exception of
MentionWarnings, which I've opened #4942 for, andComposeMenu, which we have #4796 for. And of course #4926.Related: #4907