Skip to content

deps: Run yarn upgrade.#4792

Merged
chrisbobbe merged 1 commit intozulip:masterfrom
chrisbobbe:pr-yarn-upgrade-again
Jun 14, 2021
Merged

deps: Run yarn upgrade.#4792
chrisbobbe merged 1 commit intozulip:masterfrom
chrisbobbe:pr-yarn-upgrade-again

Conversation

@chrisbobbe
Copy link
Copy Markdown
Contributor

Notably, this includes an update to Sentry's SDK for React Native
that came out after the last yarn upgrade commit, in #4789, was
authored.

I got an error --

[!] CocoaPods could not find compatible versions for pod "Sentry":
  In snapshot (Podfile.lock):
    Sentry (= 6.1.4)

  In Podfile:
    RNSentry (from `../node_modules/@sentry/react-native`) was resolved to 2.5.0, which depends on
      Sentry (= 7.0.0)

You have either:
 * out-of-date source repos which you can update with `pod repo update` or with `pod install --repo-update`.
 * changed the constraints of dependency `Sentry` inside your development pod `RNSentry`.
   You should run `pod update Sentry` to apply changes you've made.

-- so I ran pod update Sentry, and it went through. After that, I
ran yarn (with pod install getting run in the postinstall
script), and no further changes were made.

We should aim to have this out in a beta for a little while, to
shake out any bugs. In addition to this Sentry upgrade, quite a lot
of other stuff seems to have been touched.

@chrisbobbe chrisbobbe requested review from WesleyAC and gnprice June 11, 2021 00:29
@chrisbobbe
Copy link
Copy Markdown
Contributor Author

If you take a look at the "rich diff" for yarn.lock, you'll see that all these new versions of things (there are a lot!!) were just released in the past couple days:

image

Notably, this includes an update to Sentry's SDK for React Native
that came out after the last `yarn upgrade` commit, in zulip#4789, was
authored.

I got an error --

```
[!] CocoaPods could not find compatible versions for pod "Sentry":
  In snapshot (Podfile.lock):
    Sentry (= 6.1.4)

  In Podfile:
    RNSentry (from `../node_modules/@sentry/react-native`) was resolved to 2.5.0, which depends on
      Sentry (= 7.0.0)

You have either:
 * out-of-date source repos which you can update with `pod repo update` or with `pod install --repo-update`.
 * changed the constraints of dependency `Sentry` inside your development pod `RNSentry`.
   You should run `pod update Sentry` to apply changes you've made.
```

-- so I ran `pod update Sentry`, and it went through. After that, I
ran `yarn` (with `pod install` getting run in the postinstall
script), and no further changes were made.

We should aim to have this out in a beta for a little while, to
shake out any bugs. In addition to this Sentry upgrade, quite a lot
of other stuff seems to have been touched.
@chrisbobbe chrisbobbe force-pushed the pr-yarn-upgrade-again branch from 4ee9c04 to 4dd471c Compare June 11, 2021 16:50
@chrisbobbe chrisbobbe changed the title deps: Run yarn update. deps: Run yarn upgrade. Jun 11, 2021
Copy link
Copy Markdown
Contributor

@WesleyAC WesleyAC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@chrisbobbe
Copy link
Copy Markdown
Contributor Author

all these new versions of things (there are a lot!!) were just released in the past couple days:

Correction, I see some Sentry-related ones that were released 9 days ago; that would have predated the previous yarn upgrade. I'd guess that those versions just weren't compatible with the version ranges as they stood after the previous yarn upgrade and before this one (this one, as noted, upgraded @sentry/react-native).

@chrisbobbe chrisbobbe merged commit 4dd471c into zulip:master Jun 14, 2021
@chrisbobbe
Copy link
Copy Markdown
Contributor Author

chrisbobbe commented Jun 14, 2021

LGTM :)

Thanks for the review! Merged.

@gnprice
Copy link
Copy Markdown
Member

gnprice commented Jun 15, 2021

Thanks @chrisbobbe for taking these updates!

It looks like a lot of new versions in sheer number-of-packages terms, but the bulk of them are either Babel or Sentry. So I think a more accurate picture may be: it's a handful of updates, two of which are to Babel and Sentry -- both of which are projects that have a practice of splitting up their code into lots and lots of packages.

E.g. try du -sh node_modules/@babel/*/ | sort -rh. There are 117 packages there… and the majority of them take up 24 kiB on disk. And even that sounds a lot bigger than these packages actually are: du counts each file as occupying at least one 4 kiB block. So you get to 24 kiB just by having a few hundred bytes of actual code plus a scattering of metadata:

$ tree node_modules/@babel/plugin-transform-unicode-regex/
node_modules/@babel/plugin-transform-unicode-regex/
├── lib
│   └── index.js
├── LICENSE
├── package.json
└── README.md

$ wc node_modules/@babel/plugin-transform-unicode-regex/lib/index.js 
 19  40 527 node_modules/@babel/plugin-transform-unicode-regex/lib/index.js

chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this pull request Jun 24, 2021
Notably, this includes a few patches to Sentry's SDK for React
Native that came out after v2.5.0, which we took in our last `yarn
upgrade` (zulip#4792). We go up to v2.5.2:
  https://github.com/getsentry/sentry-react-native/releases
@chrisbobbe
Copy link
Copy Markdown
Contributor Author

It looks like a lot of new versions in sheer number-of-packages terms, but the bulk of them are either Babel or Sentry.

Makes sense, thanks!

chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this pull request Jun 24, 2021
Notably, this includes a few patches to Sentry's SDK for React
Native that came out after v2.5.0, which we took in our last `yarn
upgrade` (zulip#4792). We go up to v2.5.2:
  https://github.com/getsentry/sentry-react-native/releases
@chrisbobbe chrisbobbe deleted the pr-yarn-upgrade-again branch July 30, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants