deps: Remove prop-types from devDependencies.#4779
Merged
chrisbobbe merged 1 commit intozulip:masterfrom Jun 4, 2021
Merged
Conversation
We added it in 5b6014e to silence a peer-dep warning that react-intl hasn't been throwing for a while: formatjs/formatjs#1382 Note that react-intl's package.json doesn't have prop-types in its peerDependencies anymore: https://github.com/formatjs/formatjs/blob/react-intl%405.8.6/packages/react-intl/package.json#L144-L147 The package is for runtime checking for React props; we don't need it because we use Flow: https://www.npmjs.com/package/prop-types
chrisbobbe
force-pushed
the
pr-remove-prop-types
branch
from
08642b7 to
28b42c9
Compare
Contributor
Author
|
Thanks for the review! Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added it in 5b6014e to silence a peer-dep warning that
react-intl hasn't been throwing for a while:
formatjs/formatjs#1382
Note that react-intl's package.json doesn't have prop-types in its
peerDependencies anymore:
https://github.com/formatjs/formatjs/blob/react-intl%405.8.6/packages/react-intl/package.json#L144-L147
The package is for runtime checking for React props; we don't need
it because we use Flow:
https://www.npmjs.com/package/prop-types