dependabot: Add config file.#4778
Merged
chrisbobbe merged 3 commits intozulip:masterfrom Jun 4, 2021
Merged
Conversation
WesleyAC
approved these changes
Jun 4, 2021
Contributor
WesleyAC
left a comment
WesleyAC
left a comment
There was a problem hiding this comment.
LGTM! I'm a bit worried about noise, but happy to try it out and see what happens.
Contributor
Author
|
Thanks for the review! Merged. We can always lower |
Contributor
Author
|
I like that Dependabot links (and sometimes quotes) the changelog for the package; it saves some clicking around in GitHub which can be slow. |
I noticed this while looking at https://lgtm.com/projects/g/zulip/zulip-mobile/. It looks like LGTM (and GitHub's "CodeQL", which uses it) isn't ready to support Flow yet [1], and I think that's causing a lot of noise into the alerts there. So, while this tool isn't quite ready for us to use in CI yet, maybe we can check back on it at some point? :) [1] github/codeql#6016
I'm not sure what practical difference this makes, but it's in a file dedicated to types, so it seems right to use `import type`. I noticed this while looking at https://lgtm.com/projects/g/zulip/zulip-mobile/. It looks like LGTM (and GitHub's "CodeQL", which uses it) isn't ready to support Flow yet [1], and I think that's causing a lot of noise into the alerts there. So, while this tool isn't quite ready for us to use in CI yet, maybe we can check back on it at some point? :) [1] github/codeql#6016
Currently, dependabot will automatically open PRs to address reported security vulnerabilities in packages. I'm interested to see if it can help us be better about keeping our packages up-to-date in general. There are plenty of config options we can choose from (see the linked doc). For now, I'm just curious to see what it does with this simple config.
chrisbobbe
force-pushed
the
pr-dependabot-config
branch
from
4d2304c to
0f83ab8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, dependabot will automatically open PRs to address
reported security vulnerabilities in packages. I'm interested to see
if it can help us be better about keeping our packages up-to-date in
general.
There are plenty of config options we can choose from (see the
linked doc). For now, I'm just curious to see what it does with this
simple config.