ComposeBox: Don't require caughtUp to send in stream narrow.#4772
Closed
WesleyAC wants to merge 1 commit intozulip:masterfrom
Closed
ComposeBox: Don't require caughtUp to send in stream narrow.#4772WesleyAC wants to merge 1 commit intozulip:masterfrom
WesleyAC wants to merge 1 commit intozulip:masterfrom
Conversation
See CZO [1] for some background on this. There are many reasons why the destination narrow might not be the caughtUp narrow in the stream view, and it's worse to prevent the user from sending with a cryptic error message than it is to allow them to send to a narrow they aren't fully caught up in. [1]: https://chat.zulip.org/#narrow/stream/48-mobile/topic/Failed.20to.20send.20on.20Android
Contributor
Author
|
Superseded by #4773. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See CZO 1 for some background on this. There are many reasons why the
destination narrow might not be the caughtUp narrow in the stream view,
and it's worse to prevent the user from sending with a cryptic error
message than it is to allow them to send to a narrow they aren't fully
caught up in.