ComposeBox: Don't set topic by default in stream narrows.#4769
Closed
WesleyAC wants to merge 4 commits intozulip:masterfrom
Closed
ComposeBox: Don't set topic by default in stream narrows.#4769WesleyAC wants to merge 4 commits intozulip:masterfrom
WesleyAC wants to merge 4 commits intozulip:masterfrom
Conversation
WesleyAC
force-pushed
the
composebox-remove-lastmessagetopic
branch
from
69a388a to
91cae0b
Compare
This is typically confusing to users, so just remove it and force people to specify the topic they want. We should follow up by having the "Topic" input be the default thing that's focused, rather than the "Message" input. Fixes: zulip#4764
WesleyAC
force-pushed
the
composebox-remove-lastmessagetopic
branch
from
91cae0b to
6b3b33f
Compare
This will allow us to use getCanSelectTopic when we're constructing the initial state.
Contributor
Author
|
Added two commits to this PR that do some cleanup on ComposeBox (making the types reflect reality more). |
Previously, the state.topic variable was an empty string in narrows with no topic, which made it annoying to distinguish that state from being in a stream or topic narrow with the topic box empty.
WesleyAC
force-pushed
the
composebox-remove-lastmessagetopic
branch
from
d18e9f1 to
30ab947
Compare
Since we've stopped autofilling the topic textbox, we want to show the autocomplete when the user first selects the topic textbox.
Contributor
Author
|
Hmmm, the last commit in this stack seems pretty buggy, I'm not sure if RN offers a nice way to do what I'm trying to do. The other commits should still be good for review, though. |
WesleyAC
force-pushed
the
composebox-remove-lastmessagetopic
branch
from
ba148d3 to
822d2ff
Compare
Contributor
Author
|
Superseded by #4773. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is typically confusing to users, so just remove it and force people
to specify the topic they want.
We should follow up by having the "Topic" input be the default thing
that's focused, rather than the "Message" input.
Fixes: #4764