flipper ios: Pin to some specific versions, to fix build with Xcode 12.5.#4721
Merged
gnprice merged 2 commits intozulip:masterfrom May 6, 2021
Merged
flipper ios: Pin to some specific versions, to fix build with Xcode 12.5.#4721gnprice merged 2 commits intozulip:masterfrom
gnprice merged 2 commits intozulip:masterfrom
Conversation
chrisbobbe
added
a-iOS
upstream: RN
chrisbobbe
force-pushed
the
pr-xcode-12.5-build-fix
branch
from
7e75f31 to
4bb776e
Compare
Contributor
Author
|
It'd be great to know if this breaks builds with Xcode <12.5, I guess, if that's possible. Otherwise fine if not, and we can just tell people to use 12.5 if they run into any problems. |
Member
They do: https://developer.apple.com/download/more/ but it's annoying, partly because it's a >10GB download. LGTM, merging. |
…2.5. Following the outlined solution for projects using RN v0.63, in facebook/react-native#31480. The "properly clean your caches" step didn't seem to be necessary for me, but possibly that's different between environments. Done without looking for breaking changes, beyond confirming that the build succeeds on Xcode 12.5. There could be a lot of breaking changes between Flipper 0.54.0 and 0.75.1 -- but we don't use Flipper yet (that's zulip#4255) and we don't have anything like a Flipper config file for iOS.
As we made plans for in the RN v0.62 upgrade. In the previous commit, the OpenSSL-Universal pod was taken to 1.1.180, which is even later than 1.0.2.20, which is what we'd been waiting for. Fixes: zulip#4264
gnprice
force-pushed
the
pr-xcode-12.5-build-fix
branch
from
4bb776e to
5997d48
Compare
Member
|
FTR, here's an example of the symptom this fixes. The build failed with the following summary: and the following more detailed error a bit earlier in the log: (That's at v27.163, which doesn't have this fix, and using Xcode 12.5 build 12E262.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds are failing with Xcode 12.5, and mine auto-updated this morning; here's a fix. (And a follow-up commit that resolves an unrelated issue.)
I've marked this P0 because iOS development/testing for any purpose (e.g., code review) is halted, for me and for anyone else whose Xcode got (auto-)updated; please let me know if this is wrong. I don't think Apple lets you downgrade Xcode after upgrading?