Add tests for `ZulipAsyncStorage.getItem` and `.setItem`.#4709

Merged

gnprice merged 14 commits into

zulip:masterfrom

chrisbobbe:pr-zulip-async-storage-tests

Jun 3, 2021

Commits on Jun 3, 2021

MainTabsScreen [nfc]: Make it clear that `isPad` is iOS-only.

chrisbobbe
authored and
gnprice
committed
ZulipAsyncStorage tests: Add tests for `setItem`.

chrisbobbe
authored and
gnprice
committed
TextCompressionModule [nfc]: Add TODO for unit tests.

chrisbobbe
authored and
gnprice
committed
ZulipAsyncStorage types: Better align .setItem/.getItem with AsyncStorage.

chrisbobbe
authored and
gnprice
committed
ZulipAsyncStorage: Pass null for error, not undefined, on .getItem success.

chrisbobbe
authored and
gnprice
committed
ZulipAsyncStorage: Also call callback on `AsyncStorage.getItem` failure.

chrisbobbe
authored and
gnprice
committed
ZulipAsyncStorage tests: Add tests for `getItem`.

chrisbobbe
authored and
gnprice
committed
ZulipAsyncStorage tests: Add test for `getItem` / `setItem` together.

chrisbobbe
authored and
gnprice
committed
redux-persist [nfc]: Remove some inactive code paths we'll never use.

chrisbobbe
authored and
gnprice
committed
redux-persist: Make early `return` explicit.

chrisbobbe
authored and
gnprice
committed
redux-persist [nfc]: Stop using callbacks with `ZulipAsyncStorage.foo`.

chrisbobbe
authored and
gnprice
committed
ZulipAsyncStorage [nfc]: Drop support for passing callbacks.

chrisbobbe
authored and
gnprice
committed
reduxTypes: Mark `GlobalState`'s properties as read-only.

chrisbobbe
authored and
gnprice
committed
storage: Start testing several pieces of the Redux storage logic at once.

chrisbobbe
authored and
gnprice
committed