caughtUp: Fix bug that overwrote CaughtUp state.#4698
Merged
gnprice merged 1 commit intozulip:masterfrom Apr 27, 2021
Merged
Conversation
Merged
When we made a request for a narrow, we would overwrite the CaughtUp state for that narrow in the other direction - i.e. if we were fetching old messages, then we would forget that we've seen the most recent message. This commit fixes that by only updating each bit of the CaughtUp state from false to true (on a fetch-messages result), and never the other way around.
gnprice
force-pushed
the
fix-caughtup-overwrite-bug
branch
from
5bc6429 to
4cc6788
Compare
Member
|
Looks good, thanks, merged! For cross-reference in the future when this is no longer obvious: a previous version of this change was in drafts of #4678 and discussed there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we made a request for a narrow, we would overwrite the CaughtUp
state for that narrow in the other direction - i.e. if we were fetching
old messages, then we would forget that we've seen the most recent
message.
This commit fixes that by only updating each bit of the CaughtUp state
from false to true (on a fetch-messages result), and never the other
way around.