Structure redux-persist code toward doing writes in batches with `AsyncStorage.multiSet`.#4694

Merged

gnprice merged 17 commits into

zulip:mainfrom

chrisbobbe:pr-redux-persist-multi-set

Sep 15, 2021

Commits on Sep 15, 2021

createPersistor [nfc]: Use a stateful `writeInProgress` flag.

chrisbobbe
authored and
gnprice
committed
createPersistor: Simplify "paused" logic a bit.

chrisbobbe
authored and
gnprice
committed
createPersistor: Stop blending snapshots when we initiate writes.

chrisbobbe
authored and
gnprice
committed
createPersistor [nfc]: Rename `storesToProcess` to `updatedSubstates`.

chrisbobbe
authored and
gnprice
committed
createPersistor: Rewrite a loop with `while` and `await`.

chrisbobbe
authored and
gnprice
committed
createPersistor: Clean up a `while` loop, using a loop condition.

chrisbobbe
authored and
gnprice
committed
createPersistor: Include more code in an async IIFE.

chrisbobbe
authored and
gnprice
committed
createPersistor: Separate serializing from writing.

chrisbobbe
authored and
gnprice
committed
createPersistor: Use `storage.multiSet` instead of many `.setItem`s.

chrisbobbe
authored and
gnprice
committed
createPersistor: Await `storage.multiSet` before marking state as written.

chrisbobbe
authored and
gnprice
committed
createPersistor [nfc]: Define `writeOnce`, with a jsdoc.

chrisbobbe
authored and
gnprice
committed
createPersistor [nfc]: Tidy up some code, and comment.

chrisbobbe
authored and
gnprice
committed
createPersistor: Move a yield from before to after serializing.

chrisbobbe
authored and
gnprice
committed
createPersistor [nfc]: Tidy up some more code, and comment.

chrisbobbe
authored and
gnprice
committed
createPersistor [nfc]: Comment some more.

chrisbobbe
authored and
gnprice
committed
createPersistor: Stop ignoring state changes that happen during a write.

chrisbobbe
authored and
gnprice
committed
createPersistor [nfc]: Inline a complicated helper function we use once.

chrisbobbe
authored and
gnprice
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Structure redux-persist code toward doing writes in batches with `AsyncStorage.multiSet`.#4694

Structure redux-persist code toward doing writes in batches with `AsyncStorage.multiSet`.#4694
gnprice merged 17 commits into
zulip:mainfrom
chrisbobbe:pr-redux-persist-multi-set

Commits on Sep 15, 2021

createPersistor [nfc]: Use a stateful `writeInProgress` flag.

createPersistor: Simplify "paused" logic a bit.

createPersistor: Stop blending snapshots when we initiate writes.

createPersistor [nfc]: Rename `storesToProcess` to `updatedSubstates`.

createPersistor: Rewrite a loop with `while` and `await`.

createPersistor: Clean up a `while` loop, using a loop condition.

createPersistor: Include more code in an async IIFE.

createPersistor: Separate serializing from writing.

createPersistor: Use `storage.multiSet` instead of many `.setItem`s.

createPersistor: Await `storage.multiSet` before marking state as written.

createPersistor [nfc]: Define `writeOnce`, with a jsdoc.

createPersistor [nfc]: Tidy up some code, and comment.

createPersistor: Move a yield from before to after serializing.

createPersistor [nfc]: Tidy up some more code, and comment.

createPersistor [nfc]: Comment some more.

createPersistor: Stop ignoring state changes that happen during a write.

createPersistor [nfc]: Inline a complicated helper function we use once.