replaceRevive [nfc]: Fix a latent bug caused by a sketchy null check.#4463
Merged
gnprice merged 1 commit intozulip:masterfrom Feb 5, 2021
Merged
replaceRevive [nfc]: Fix a latent bug caused by a sketchy null check.#4463gnprice merged 1 commit intozulip:masterfrom
gnprice merged 1 commit intozulip:masterfrom
Conversation
This is only latent because, so far, we only use `ImmutableMapNumKeys` for `state.messages`. Greg confirms that it would be very surprising if a message could have an ID of zero [1]. [1] https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/replaceRevive.20bug/near/1112480
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is only latent because, so far, we only use
ImmutableMapNumKeysforstate.messages. Greg confirms that itwould be very surprising if a message could have an ID of zero [1].
[1] https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/replaceRevive.20bug/near/1112480