UserStatusScreen: Convert to use hooks & react navigation v5#4447
Open
karanb1 wants to merge 1 commit intozulip:mainfrom
Open
UserStatusScreen: Convert to use hooks & react navigation v5#4447karanb1 wants to merge 1 commit intozulip:mainfrom
karanb1 wants to merge 1 commit intozulip:mainfrom
Conversation
Conversion of class based component into function based component. Replacing NavigationService with the v5 useNavigation Hook. Removing connect and the dispatch with appropriate useSelector and useDispatch redux hooks Using useState hook to handle local state of the component.
karanb1
changed the title
Author
|
@chrisbobbe Thank you for allowing me to work on this issue, can you please review my code. I am planning to add more commits to this PR with changes to other components as well, your feedback will help me in making the right changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the PR in the series of cleanup of navigation logic and component.
Following #4443, It converts the UserStatusScreen into hooks based component. NavigationService is replaced with the action provided by the useNavigation Hooks.