User Status Screen Conversion To Hooks#4445
Closed
karanb1 wants to merge 8 commits intozulip:masterfrom
karanb1:pr-hooks-conversion
Closed
User Status Screen Conversion To Hooks#4445karanb1 wants to merge 8 commits intozulip:masterfrom karanb1:pr-hooks-conversion
karanb1 wants to merge 8 commits intozulip:masterfrom
karanb1:pr-hooks-conversion
Conversation
Author
|
As this is my first contribution in this project, I had a few problems with ES lint configurations which I resolved eventually. @chrisbobbe please can you review this and guide me with necessary changes(if required). |
Contributor
|
@karanb1 I suggest you should squash all your commits into one single commit also there are some branch conflicts you should also resolve them. |
Author
|
Thank you @abhi0504 for the suggestion. I will close this PR and create a new pull request according to the links you provided. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the PR in the series that began with #4428..
It converts the user state class based component into hooks based component. I plan to further migrate more components to React navigation v5 standards, hook based lifecycle methods and redux hooks standards.