swipe from message view back #4398
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -59,7 +59,14 @@ export const createAppNavigator = (args: {| | |
| 'account-details': { screen: AccountDetailsScreen }, | ||
| 'group-details': { screen: GroupDetailsScreen }, | ||
| auth: { screen: AuthScreen }, | ||
| chat: { screen: ChatScreen, | ||
| navigationOptions:{ | ||
| gestureEnabled:true, | ||
| gestureDirection:'horizontal', | ||
| gestureResponseDistance:{ | ||
| horizontal:20 | ||
|
||
| } | ||
| } }, | ||
| dev: { screen: DevAuthScreen }, | ||
| 'emoji-picker': { screen: EmojiPickerScreen }, | ||
| loading: { screen: LoadingScreen }, | ||
|
|
@@ -74,7 +81,14 @@ export const createAppNavigator = (args: {| | |
| 'message-reactions': { screen: MessageReactionList }, | ||
| password: { screen: PasswordAuthScreen }, | ||
| realm: { screen: RealmScreen }, | ||
| search: { screen: SearchMessagesScreen, | ||
| navigationOptions:{ | ||
| gestureEnabled:true, | ||
| gestureDirection:'horizontal', | ||
| gestureResponseDistance:{ | ||
| horizontal:20 | ||
| } | ||
| } }, | ||
| users: { screen: UsersScreen }, | ||
| language: { screen: LanguageScreen }, | ||
| lightbox: { screen: LightboxScreen }, | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you arrive at the choice to configure the particular routes
chatandsearch? 🙂 Did you find a reason not to apply the changes to all routes onAppNavigator, e.g., withdefaultNavigationOptions?I think this is a place where consistency would be helpful; a user might get confused if they find they can sometimes use the gesture and sometimes not, in similar situations. For that reason, I think using
defaultNavigationOptionswould be a good idea.The doc I linked to in #4036 says that we should be careful to avoid situations where two things are set up to respond to the same gesture, with one of them being this new back-navigation handling. Did you find a situation like that? If so, it might be helpful to "opt out" of the back-nav gesture for that particular screen (if we can't easily just get rid of the pre-existing gesture handling) by, e.g., setting
gestureEnabled: falseon that screen—rather than "opting in" to the feature for just one or two screens.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered the issue #4036 is being refer to giving user an alternative and a familiar way to navigate back from the message(chat) screen (swipping left to right).
I considered to apply the same thing on the search route to make goback action( by swipping left to right ) consistent for all the options( all message, starred, mention, search) in upperTabNavigator.
Yes, I agree to this point.
Should I consider applying it as
defaultNavigationOptions?No, I could not find any situation like that. On Android no gestures are registered for the action swipe from left to right.
Also I have read in docs that states gestures are enabled by default in IOS and not on Android, so a platform specific code can be written to use gestures in
defaultNavigationOptions.Can this be considered as a point of consistency for users on different platforms(IOS and Android) ?.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, let's try that.
Yes, let's use
Platform.selectto apply the new settings to Android only. The new settings may coincide with the default settings on iOS, but navigation is one of the areas where iOS and Android have important differences in how they want navigation to be handled, so I think it makes sense for our code to treat the two platforms separately here.