Skip to content

React Navigation v5 upgrade (part 2) #4393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisbobbe merged 25 commits into from
Jan 14, 2021
Merged

React Navigation v5 upgrade (part 2) #4393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
71992d2
screen types [nfc]: Rewrite `navigation` type for screens on AppNavig…
chrisbobbe Nov 7, 2020
b09325a
screen types [nfc]: Rewrite `navigation` type for screens on `MainTabs`.
chrisbobbe Nov 10, 2020
48cf5ca
screen types [nfc]: Rewrite `navigation` type for screens on `StreamT…
chrisbobbe Nov 10, 2020
c08e882
screen types [nfc]: Rewrite `navigation` type for screens on SharingS…
chrisbobbe Nov 10, 2020
e764419
tabs: Add `elevation: 0` to base tab-nav config's tab bar style.
chrisbobbe Nov 17, 2020
07f748e
MessageReactionList: Pass `initialRouteName`, even if `undefined`.
chrisbobbe Nov 10, 2020
ac378a7
MessageReactionList [nfc]: Replace `getReactionsTabs` with two functi…
chrisbobbe Nov 10, 2020
59ed926
ZulipAppContainer: Pass `theme` prop to `AppContainer`.
chrisbobbe Nov 11, 2020
1731f4f
nav [nfc]: Remove some soon-to-be-unnecessary comments.
chrisbobbe Nov 11, 2020
64a928f
deps: Add libdefs for new, differently named React Navigation packages.
chrisbobbe Nov 12, 2020
8c51a39
react-navigation libdef: Move out of `npm` directory, preparing for e…
chrisbobbe Jan 12, 2021
f92a8e2
prettier: Ignore flow-typed/@react-navigation.
chrisbobbe Jan 13, 2021
f7c1629
react-navigation libdef: Make *NavigationProp covariant in RouteName …
chrisbobbe Jan 12, 2021
05d2e0d
react-navigation libdef: Fix `getRootState`.
chrisbobbe Jan 13, 2021
1228450
deps: Upgrade to React Navigation v5.
chrisbobbe Oct 14, 2020
1db60d2
deps: Clear out old libdefs for react-navigation.
chrisbobbe Nov 12, 2020
0fed2a6
MessageReactionList [nfc]: Inline some helper functions.
chrisbobbe Nov 11, 2020
140c28c
navActions: Stop using @react-navigation/compat.
chrisbobbe Nov 11, 2020
6f74614
ChatScreen: Stop using @react-navigation/compat.
chrisbobbe Nov 11, 2020
6bbea37
MainTabs: Stop using @react-navigation/compat.
chrisbobbe Nov 11, 2020
ce7bf0c
AppNavigator: Stop using @react-navigation/compat.
chrisbobbe Nov 11, 2020
89a9b6c
SharingScreen: Stop using @react-navigation/compat.
chrisbobbe Nov 12, 2020
72c9e4b
StreamTabs: Stop using @react-navigation/compat.
chrisbobbe Nov 12, 2020
60c9c68
deps: Remove @react-navigation/compat.
chrisbobbe Nov 12, 2020
dd6ef39
AppNavigator [nfc]: Stop getting some values from the parent component.
chrisbobbe Jan 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,9 @@
src/emoji/__tests__/data-test.js

# We're not allowing Prettier to touch some of our vendored code.
src/third/redux-persist
src/third/redux-persist

# We'd like to keep the original formatting for some Flow libdefs from
# FlowTyped, to make it easier to eventually make a PR back to
# FlowTyped.
Comment on lines +7 to +9
Copy link
Member

@gnprice gnprice Jan 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

ESLint already ignores them because of the `**/__flow-tests__/**`
line in `.eslintignore`.

nit: I think you mean the other line, **/flow-typed/**

Copy link
Contributor Author

@chrisbobbe chrisbobbe Jan 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thanks.

flow-typed/@react-navigation
Loading