Refresh the still-useful parts of #4116, on path to using recent-PMs data#4358

Merged

chrisbobbe merged 15 commits into

zulip:masterfrom

gnprice:pr-4116-updated

Dec 29, 2020

Commits on Dec 29, 2020

pm-conversations [nfc]: Rename some variables, mostly for clarity.

rk-for-zulip
authored and
gnprice
committed
types: Drop a redundant `$Exact<...>`.
gnprice
committed
example data [nfc]: Allow specifying `user_id` when making a user.

rk-for-zulip
authored and
gnprice
committed
example data: Explain why we don't sort recipients in pmMessage.
gnprice
committed
example data: Add auxiliary function `pmMessageFromTo`.

rk-for-zulip
authored and
gnprice
committed
tests [nfc]: Use the new `eg.pmMessageFromTo` more.
gnprice
committed
example data: Add auxiliary function `makeMessagesState`.

rk-for-zulip
authored and
gnprice
committed
pm-conversations tests: Simplify using eg.makeMessagesState.

rk-for-zulip
authored and
gnprice
committed
tests: Use new eg.makeMessagesState where applicable.
gnprice
committed
types [nfc]: Add jsdoc for the fields of PmConversationData.

rk-for-zulip
authored and
gnprice
committed
types: Use React$ElementConfig rather than $PropertyType<..., 'props'>.
gnprice
committed
pm UI [nfc]: Stop passing around disused allUsersByEmail.

rk-for-zulip
authored and
gnprice
committed
pm-conversations tests [nfc]: Pull out keyForUsers.
gnprice
committed
pm-conversations tests [nfc]: Tighten formatting to fit better on screen.
gnprice
committed
pm-conversations tests: Fix inconsistent test data.
gnprice
committed