Open links in different ways (browser and webview)#4343
Closed
shaurya2612 wants to merge 4 commits into
Closed
Conversation
There are two functions for opening links, openLinkEmbedded will open links in embedded webview for both android and ios while openLink will open links in browser for ios and in webview for android
As the previous commit (b19a686) introducedopenLinkEmbedded, webAuth and AuthScreen shall use it for a better user experience while logging in
Contributor
Author
|
I went through all the
@gnprice what do you think? |
Collaborator
|
Closing, as this was taken care of in #4679. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is in continuation of #4336 and resolves issue #4323
I've added a seperate function called openLinkEmbedded for opening links in webview, as stated in -#4336 (comment) - I have made changes to open a webview in
AuthScreen.jsandwebAuth.js.