narrow: Encapsulate the Narrow type within its module, checked with an opaque type#4342

Merged

chrisbobbe merged 15 commits into

zulip:masterfrom

gnprice:pr-narrow-opaque

Dec 17, 2020

Commits on Dec 17, 2020

narrow [nfc]: Distinguish ApiNarrow type, with an alias for now.

gnprice
authored and
chrisbobbe
committed
narrow tests: Stop constructing narrows as array literals.

gnprice
authored and
chrisbobbe
committed
tests: Stop constructing narrows as literals.

gnprice
authored and
chrisbobbe
committed
unreads [nfc]: Simplify `getUnreadCountForNarrow` slightly.

gnprice
authored and
chrisbobbe
committed
unreads [nfc]: Simplify `getUnreadCountForNarrow` a bit more.

gnprice
authored and
chrisbobbe
committed
unreads [nfc]: Unpack narrow structurally in getUnreadCountForNarrow.

gnprice
authored and
chrisbobbe
committed
compose [nfc]: Unpack narrow structurally in getComposeInputPlaceholder.

gnprice
authored and
chrisbobbe
committed
compose [nfc]: Cut a bit of code for impossible conditions.

gnprice
authored and
chrisbobbe
committed
narrow [nfc]: Add a getter emailsOfPmNarrow, and use it.

gnprice
authored and
chrisbobbe
committed
narrow [nfc]: Add getters for stream name and topic; use them.

gnprice
authored and
chrisbobbe
committed
narrow [nfc]: Add getter emailOfPm1to1Narrow, and use it.

gnprice
authored and
chrisbobbe
committed
narrow [nfc]: Use sensible explicit bits of API for home narrow, too.

gnprice
authored and
chrisbobbe
committed
narrow tests: Stop caring about the internal representation entirely.

gnprice
authored and
chrisbobbe
committed
narrow [nfc]: Explicitly convert to ApiNarrow where appropriate.

gnprice
authored and
chrisbobbe
committed
narrow types: Make Narrow an opaque type.

gnprice
authored and
chrisbobbe
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

narrow: Encapsulate the Narrow type within its module, checked with an opaque type#4342

narrow: Encapsulate the Narrow type within its module, checked with an opaque type#4342
chrisbobbe merged 15 commits into
zulip:masterfrom
gnprice:pr-narrow-opaque

Commits on Dec 17, 2020

narrow [nfc]: Distinguish ApiNarrow type, with an alias for now.

narrow tests: Stop constructing narrows as array literals.

tests: Stop constructing narrows as literals.

unreads [nfc]: Simplify `getUnreadCountForNarrow` slightly.

unreads [nfc]: Simplify `getUnreadCountForNarrow` a bit more.

unreads [nfc]: Unpack narrow structurally in getUnreadCountForNarrow.

compose [nfc]: Unpack narrow structurally in getComposeInputPlaceholder.

compose [nfc]: Cut a bit of code for impossible conditions.

narrow [nfc]: Add a getter emailsOfPmNarrow, and use it.

narrow [nfc]: Add getters for stream name and topic; use them.

narrow [nfc]: Add getter emailOfPm1to1Narrow, and use it.

narrow [nfc]: Use sensible explicit bits of API for home narrow, too.

narrow tests: Stop caring about the internal representation entirely.

narrow [nfc]: Explicitly convert to ApiNarrow where appropriate.

narrow types: Make Narrow an opaque type.