UserAvatarWithPresence: Remove dubious default prop for email.#4341
Merged
gnprice merged 1 commit intozulip:masterfrom Dec 16, 2020
Merged
Conversation
chrisbobbe
force-pushed
the
pr-lightbox-header-status-indicator
branch
from
bbf635b to
156aee4
Compare
As Greg points out, the effect of this default prop has been to suppress the presence-status indicator for the sender in the lightbox header. And since that omission is quite unlikely to be intentional, we should fix it by passing down the sender's email. [1] So, do. [1] zulip#4230 (comment)
gnprice
force-pushed
the
pr-lightbox-header-status-indicator
branch
from
156aee4 to
261b747
Compare
Member
|
Looks good, merged -- thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Greg points out, the effect of this default prop has been to
suppress the presence-status indicator for the sender in the
lightbox header. And since that omission is quite unlikely to be
intentional, we should fix it by passing down the sender's email.
So, do.
[1] #4230 (comment)