Crunchify shell for avatar URLs, handle `user_avatar_url_field_optional` client capability#4230

Merged

chrisbobbe merged 23 commits into

zulip:masterfrom

chrisbobbe:pr-avatar-url

Dec 15, 2020

Commits on Dec 15, 2020

eslint [nfc]: Correct a few errors in comments.
chrisbobbe
committed
UserAvatarWithPresence: Stop double-processing avatar URLs.
chrisbobbe
committed
UserAvatarWithPresence [nfc]: Remove unused default prop for `size`.
chrisbobbe
committed
avatar [nfc]: Move default size of 80 to `getAvatar*` functions' callsites.
chrisbobbe
committed
avatar: Clearly differentiate physical from layout pixels for avatars.
chrisbobbe
committed
avatar: Handle neglected cases where server sends a Gravatar URL.
chrisbobbe
committed
UserAvatar [nfc]: Take `.avatar_url` on a `Message` or a `UserOrBot`.
chrisbobbe
committed
AccountDetails [nfc]: Inline `AVATAR_SIZE`.
chrisbobbe
committed
usersReducer: Handle `EVENT_USER_UPDATE` a little bit.
chrisbobbe
committed
avatar: Add `AvatarURL` abstract class, and two subclasses.
chrisbobbe
committed
initialDataTypes: Add `RawInitialData`.
chrisbobbe
committed
register response [nfc]: Prepare to transform users and bots.
chrisbobbe
committed
redux: Replace/revive AvatarURL subclass instances.
chrisbobbe
committed
fetchActions tests [nfc]: Move `serverMessage1` up a level.
chrisbobbe
committed
UserAvatarWithPresence [nfc]: Remove default prop for `avatarUrl`.
chrisbobbe
committed
avatar [nfc]: Make `getAvatarUrl` use the AvatarURL class.
chrisbobbe
committed
crunchy shell: Use AvatarURL for Message objects.
chrisbobbe
committed
crunchy shell: Use AvatarURL for User and CrossRealmBot objects.
chrisbobbe
committed
UserAvatarWithPresence types [nfc]: Spell `avatarUrl`'s type more simply.
chrisbobbe
committed
UserAvatar types [nfc]: Spell `avatarUrl`'s type more simply.
chrisbobbe
committed
avatar [nfc]: Remove `getAvatarUrl`, which is now unused.
chrisbobbe
committed
getMessages: Send `client_gravatar`.
chrisbobbe
committed
registerForEvents: Start sending `user_avatar_url_field_optional`.
chrisbobbe
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Crunchify shell for avatar URLs, handle `user_avatar_url_field_optional` client capability#4230

Crunchify shell for avatar URLs, handle `user_avatar_url_field_optional` client capability#4230
chrisbobbe merged 23 commits into
zulip:masterfrom
chrisbobbe:pr-avatar-url

Commits on Dec 15, 2020

eslint [nfc]: Correct a few errors in comments.

UserAvatarWithPresence: Stop double-processing avatar URLs.

UserAvatarWithPresence [nfc]: Remove unused default prop for `size`.

avatar [nfc]: Move default size of 80 to `getAvatar*` functions' callsites.

avatar: Clearly differentiate physical from layout pixels for avatars.

avatar: Handle neglected cases where server sends a Gravatar URL.

UserAvatar [nfc]: Take `.avatar_url` on a `Message` or a `UserOrBot`.

AccountDetails [nfc]: Inline `AVATAR_SIZE`.

usersReducer: Handle `EVENT_USER_UPDATE` a little bit.

avatar: Add `AvatarURL` abstract class, and two subclasses.

initialDataTypes: Add `RawInitialData`.

register response [nfc]: Prepare to transform users and bots.

redux: Replace/revive AvatarURL subclass instances.

fetchActions tests [nfc]: Move `serverMessage1` up a level.

UserAvatarWithPresence [nfc]: Remove default prop for `avatarUrl`.

avatar [nfc]: Make `getAvatarUrl` use the AvatarURL class.

crunchy shell: Use AvatarURL for Message objects.

crunchy shell: Use AvatarURL for User and CrossRealmBot objects.

UserAvatarWithPresence types [nfc]: Spell `avatarUrl`'s type more simply.

UserAvatar types [nfc]: Spell `avatarUrl`'s type more simply.

avatar [nfc]: Remove `getAvatarUrl`, which is now unused.

getMessages: Send `client_gravatar`.

registerForEvents: Start sending `user_avatar_url_field_optional`.