Automate translation-database integration (alternate) #4063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rk-for-zulip
force-pushed
the
automate-tx-hookup-alt
branch
from
11eff08 to
36de5cb
Compare
For convenience when comparing to file lists and other databases, list languages in the source code by locale code, not by English name. Sort languages for display when exporting, to preserve the existing order in the language-selection menu.
In an upcoming commit, we'll add a YAML file to control our set of available languages. Add this as a dependency so that we can include it from there. (This package, and this version thereof, is already used by ESLint. The absence of a `yarn.lock` change in this commit is due to that, and is not an error.)
Add a configuration file for our translation databases. The data, and much of the commentary, in this file is taken from `src/settings/languages.js`, with a few minor changes. The latter file will be replaced with something autogenerated from this new file in an upcoming commit.
Create a script (intended for use immediately after a Transifex pull) to create automatic imports of all relevant Transifex message databases. It is a known failing of this script's output -- as it is of the mostly-handwritten files which it replaces -- that all messages for all languages are loaded at app start time, rather than only once (and only if) a language is selected for use.
This replaces a number of existing files with autogenerated versions which have fewer imports. In all cases, these imports were unused. This also adds a new file, `src/i18n/language_list.js`, which is both unused and redundant with `src/settings/languages.js`. This will be amended in an upcoming commit.
By design, the data in `i18n/language_list.js` is identical to the data in `src/settings/languages.js`. Remove the latter and replace it with imports of the former.
Move the last remaining functional item in this file into its only client, `settings/LanguagePicker.js`.
rk-for-zulip
force-pushed
the
automate-tx-hookup-alt
branch
from
36de5cb to
8cd4abe
Compare
|
Updated and rebased, in light of the recent Transifex sync. No changes to non-generated code were needed. |
rk-for-zulip
added a commit
to rk-for-zulip/zulip-mobile
that referenced
this pull request
May 7, 2020
Sentry error events are often delayed: there may be multiple API calls to arbitrary routes in between the actual failed call and the breadcrumb-list being sent. To avoid any question as to which logged failure resulted in the current error event, attach the call and response as "extra" data. See discussion at zulip#4063.
rk-for-zulip
added a commit
to rk-for-zulip/zulip-mobile
that referenced
this pull request
May 7, 2020
See discussion at zulip#4063 for motivation.
rk-for-zulip
added a commit
to rk-for-zulip/zulip-mobile
that referenced
this pull request
May 7, 2020
Sentry error events are often delayed: there may be multiple API calls to arbitrary routes in between the actual failed call and the breadcrumb-list being sent. To avoid any question as to which logged failure resulted in the current error event, attach the call and response as "extra" data. See discussion at zulip#4063.
rk-for-zulip
added a commit
to rk-for-zulip/zulip-mobile
that referenced
this pull request
May 7, 2020
See discussion at zulip#4063 for motivation.
rk-for-zulip
added a commit
to rk-for-zulip/zulip-mobile
that referenced
this pull request
May 8, 2020
Sentry error events are often delayed: there may be multiple API calls to arbitrary routes in between the actual failed call and the breadcrumb-list being sent. To avoid any question as to which logged failure resulted in the current error event, attach the call and response as "extra" data. See discussion at zulip#4063.
rk-for-zulip
added a commit
to rk-for-zulip/zulip-mobile
that referenced
this pull request
May 8, 2020
See discussion at zulip#4063 for motivation.
rk-for-zulip
added a commit
to rk-for-zulip/zulip-mobile
that referenced
this pull request
May 8, 2020
See discussion at zulip#4063 for motivation.
rk-for-zulip
added a commit
to rk-for-zulip/zulip-mobile
that referenced
this pull request
May 8, 2020
Sentry error events are often delayed: there may be multiple API calls to arbitrary routes in between the actual failed call and the breadcrumb-list being sent. To avoid any question as to which logged failure resulted in the current error event, attach the call and response as "extra" data. See discussion at zulip#4063.
rk-for-zulip
added a commit
to rk-for-zulip/zulip-mobile
that referenced
this pull request
May 8, 2020
See discussion at zulip#4063 for motivation.
rk-for-zulip
added a commit
to rk-for-zulip/zulip-mobile
that referenced
this pull request
May 8, 2020
Sentry error events are often delayed: there may be multiple API calls to arbitrary routes in between the actual failed call and the breadcrumb-list being sent. To avoid any question as to which logged failure resulted in the current error event, attach the call and response as "extra" data. See discussion at zulip#4063.
rk-for-zulip
added a commit
to rk-for-zulip/zulip-mobile
that referenced
this pull request
May 8, 2020
See discussion at zulip#4063 for motivation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a script to simplify pulling translation data.
Alternative of #3915.
Fixes #3895.