Update list of offered languages #3897
Conversation
|
In particular this makes it possible to select Finnish, Galician, Korean, Lithuanian, Persian, Romanian, Swedish, and Ukrainian as the UI languages, which it wasn't before. Some of those have near-100% translations, with everything translated but a small number of recently-added (or -edited) strings. |
gnprice
changed the title
|
OK -- this now works! Thanks @ray-kraesig for providing some of the updates (as described in the relevant commit message), based on the script you've recently drafted for automating this 🙂 In addition to the two files mentioned above, Ray's branch also reminded me of the third nearly-mechanical file that needed to be updated, namely This branch now also adds docs on all the follow-up steps involved, as well as some background and context on how our translations work. |
|
One task this leaves open for a followup is adding The reason I don't include that in this branch is, as mentioned in a commit message: it'll need a migration for existing users who have |
|
@gnprice I know it's a top priority to get some support for these languages out soon, so don't let this block progress — but you may already know that @ray-kraesig's #3915, designed to subsume this one, includes adding zh-Hant and that migration you mentioned, and it looks good to me. One possible option is to merge and release everything on Ray's branch except the automation script, if you'd prefer to have more stress-testing done on that. |
Also add some general context on this subsystem.
For the libdef in flow-typed/, I reran the command in the comment at the top. For the other two, I copied changes from a draft branch of Ray's (now PR zulip#3915) which includes some scripts to fully automate generating all these files. I dropped parts of that branch's changes where it fixed naming so that we can, e.g., offer both zh-Hans and zh-Hant -- we should do that, but it'll need a migration for existing users who have `zh` in their settings, so it's not as completely trivial as the rest of these changes. Co-authored-by: Ray Kraesig <[email protected]>
Namely Finnish, Galician, Korean, Lithuanian, Persian, Romanian, Swedish, and Ukrainian. Some of these translations were contributed recently, while others have present in the code for a while... but we weren't actually offering them for users to choose in our settings UI. Oops. Fix that. :-) This is part of zulip#3895; apart from the two TODOs noted below, it gets us back to fully synced with the current state of what's translated.
|
Merged, after chatting with @ray-kraesig just now. He's also going to extract from #3915 a commit with the |
2 participants
This is part of #3895; this PR will update the current list to what it should be.
Doesn't yet work, I believe only because
locale.jsandmessages.jsaren't updated. Because @ray-kraesig is preparing a script to update those, I figure I'll hold off for a bit for that to be ready and save some effort. :)See also the series of recent commits ending at 6775b4f, which documents this list and where the nontrivial parts of its data come from.