safari view, iOS: Fix app crash when URLs contains non-ASCII. #3507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jainkuniya ! You were able to reproduce #3315, right? Can you confirm that you've tried the repro against this branch, and it fixes the issue? |
|
Yup! I am able to reproduce the issue and on this PR it is working absolutely fine 👍 |
The `SafariView` library apparently crashes when passed a `url` parameter that isn't all ASCII. Strictly such a thing isn't a URL (or URI), in fact, but rather an "IRI": https://en.wikipedia.org/wiki/Internationalized_Resource_Identifier Fix the issue by encoding the IRI in ASCII as a proper URI/URL. The standard JS function `encodeURI` does the job. Fixes: zulip#3315 [greg: expanded commit message]
|
Excellent, thanks -- merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encode url with
encodeURIbefore passing it to safari view.Refer issue thread for complete diagnosis.
Fixes: #3315