usability: Add the possibility to copy only a link from a message.#3405
Closed
ungps wants to merge 1 commit into
Closed
usability: Add the possibility to copy only a link from a message.#3405ungps wants to merge 1 commit into
ungps wants to merge 1 commit into
Conversation
Fixes zulip#3385. Long pressing on a link displays in the menu the option to copy only the link ("Copy link to clipboard") instead of copying the whole message ("Copy message to clipboard").
ungps
force-pushed
the
copy-link-long-press
branch
from
March 15, 2019 08:25
1000af2 to
d205264
Compare
Member
|
Thanks @ungps for working on this! I'm not a fan of this UX, which feels pretty subtle and easy to miss. I'd rather have long-press on a link just unconditionally copy the link. That's the approach in #3404 , so I'm closing this PR in favor of continuing discussion there and on the issue (#3385). I see there looks to have been some confusion on the issue thread #3385 about who was working on it; sorry the communication on that didn't work better. FFR, writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3385 3385. Long pressing on a link displays in the menu the option
to copy only the link ("Copy link to clipboard") instead of copying
the whole message ("Copy message to clipboard").