screen, layout: Fix white BG/panel at the bottom of screen.#3237
Merged
gnprice merged 1 commit intozulip:masterfrom Dec 27, 2018
Merged
screen, layout: Fix white BG/panel at the bottom of screen.#3237gnprice merged 1 commit intozulip:masterfrom
gnprice merged 1 commit intozulip:masterfrom
Conversation
Contributor
|
While we are fixing this more thoroughly in #3067 this is straightforward enough to merge independently. |
Apply padding instead of margin in accounting for safeAreaInsets, so that the theme's background color is painted on the whole screen. Fixes zulip#3236.
Member
|
Thanks @jainkuniya -- merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply padding instead of margin in account for safeAreaInsets, so that
theme BG color is painted on whole screen.
Fixes: #3236