Improve icon consistency#3093
Conversation
borisyankov
commented
Oct 31, 2018
borisyankov
commented
- enables correct default icon on Android (non round) (release & debug)
- provides round icons (release & debug)
- makes the iOS app use the same icon
Since Android 7.0 the launcher supports rounded icons. The default icon should be square with rounded corners. Guidelines here: https://material.io/design/iconography/#grid-keyline-shapes This replaces the default round icon with a more rectangular default one and an optional round one. The round one will be used only if that is configured in the phone's launcher. Custom icons versions were added for or Debug build too. Added new icons for: * release build, default icon * release build, rounded icon * debug build, default icon * debug build, rounded icon Added a new high-res icon option in the folders named `xxxhdpi`. Generated with the help of Android Asset Studio: http://romannurik.github.io/AndroidAssetStudio/
Previously, we have used a slightly different source image for the iOS icon. This resulted in a logo with more yellow-ish green. This uses the very same source image that is used for the Android app.
|
(#2993 is the previous PR on this subject) |
|
Thanks again @borisyankov for your work on this! The iOS commit looks great and I'd be glad to merge all those changes -- but I would like to record what that source image was. 😄 So that we don't re-create for our future selves / successors the same kind of messy situation we've found ourselves given by the past. I think you mentioned a Sketch file that you made -- would you add that to the iOS commit, or as a separate commit? On the Android side, I'm still not convinced by the switch from a round to a square icon. I would be glad to take a commit that fixed the debug icon, though; and I don't have strong preferences on exactly what that would look like. |
|
(On the Android side, the ideal thing that beats both the status quo and this change would be to use the fancy adaptive icons of Android O -- but that will take significant design effort for the amount of value it'll bring. Someday.) |
2 participants
