Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and improve autocomplete popup size #2919

Closed
wants to merge 2 commits into from
Closed

Fix and improve autocomplete popup size #2919

wants to merge 2 commits into from

Commits on Aug 26, 2018

  1. Improve autocomplete popup sizing 

    Fixes zulip#2917

Several previous changes regressed the styling of the Popup.

The ideal size of the popup can be described as:
'the whole screen sans the keyboard and with some padding around'.

The lack of CSS `position` prop value of `fixed` being supported,
and the lack of React portals (another option) support makes implementing
this tricky and requires a lot of rework.

This commit finds a good middle ground - use a max height of half the
screen height minus the compose box's height.
    @borisyankov
    borisyankov committed Aug 26, 2018
    Configuration menu
    Copy the full SHA
    80edc07 View commit details
    Browse the repository at this point in the history

  2. ui: Style Popup component better 

    Make the layout styling of Popup component more consistently:
* layout using material design padding/margin values
* 'bottom' styling is not needed
* 'shadowOpacity' and 'shadowRadius' to distinguish the popup
better from the background
    @borisyankov
    borisyankov committed Aug 26, 2018
    Configuration menu
    Copy the full SHA
    c58e689 View commit details
    Browse the repository at this point in the history