Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't immediately send attachment on upload #4540

Closed
WesleyAC opened this issue Mar 17, 2021 · 3 comments · Fixed by #5474
Closed

Don't immediately send attachment on upload #4540

WesleyAC opened this issue Mar 17, 2021 · 3 comments · Fixed by #5474
Labels
a-compose/send Compose box, autocomplete, camera/upload, outbox, sending P1 high-priority

Comments

@WesleyAC
Copy link
Contributor

WesleyAC commented Mar 17, 2021 •
edited
Loading

When a user uploads a attachment or image, it's immediately sent. Instead, we should change the behaviour to be more like the webapp: the input field should have the markdown for displaying the image inserted, but the user should be allowed to edit before sending. This will also allow people to add multiple attachments (see this CZO thread requesting this).

Related: #1903
@WesleyAC WesleyAC added the a-compose/send Compose box, autocomplete, camera/upload, outbox, sending label Mar 17, 2021
@WesleyAC WesleyAC changed the title Don't immediatly send attachment on upload Don't immediately send attachment on upload Mar 17, 2021
@vaibhavs2
Copy link
Contributor

vaibhavs2 commented Mar 24, 2021 •
edited
Loading

can it be assigned to me :)

AkashDhiman added a commit to AkashDhiman/zulip-mobile that referenced this issue Apr 3, 2021
@AkashDhiman
ComposeMenu: Update the behavior of attach file functionality.
1fa241f 
Previous functionality:
- On pressing attach file from compose menu, attachment was directly
dispatched to outbox, they should go through compose box so that a user
may add more text if desired.
- Users could only attach single files using the attach file option.

This commit modifies handleFilesPicker (previously handleFilePicker) to
support picking multiple files. After picking multiple files the
corresponding data is passed to `insertAttachment` method of ComposeBox
where the content is uploaded one by one and the ComposeBox is updated
accordingly, note that dispatch to uploadFile no longer takes place now.

Fixes: zulip#4540
Fixes: zulip#2366
@AkashDhiman AkashDhiman mentioned this issue Apr 3, 2021
Merged
AkashDhiman added a commit to AkashDhiman/zulip-mobile that referenced this issue Apr 28, 2021
@AkashDhiman
ComposeMenu: Don't immediately send attachment on upload.
cb3301e 
On pressing attach file from compose menu, attachment was directly
dispatched to outbox, they should go through compose box so that a user
may add more text if desired.

This commit creates a new function `insertAttachment` that is utilized
in `ComposeMenu`. It performs the task of uploading the attachment as
well as updating the `ComposeBox` message accordingly.

Fixes: zulip#4540
AkashDhiman added a commit to AkashDhiman/zulip-mobile that referenced this issue Apr 29, 2021
@AkashDhiman
ComposeMenu: Don't immediately send attachment on upload.
ff30117 
On pressing attach file from compose menu, attachment was directly
dispatched to outbox, they should go through compose box so that a user
may add more text if desired.

This commit creates a new function `insertAttachment` that is utilized
in `ComposeMenu`. It performs the task of uploading the attachment as
well as updating the `ComposeBox` message accordingly.

Related: zulip#4540
AkashDhiman added a commit to AkashDhiman/zulip-mobile that referenced this issue Apr 29, 2021
@AkashDhiman
ComposeMenu: Don't immediately send attachment on upload.
77f4b0b 
On pressing attach file from compose menu, attachment was directly
dispatched to outbox, they should go through compose box so that a user
may add more text if desired.

This commit creates a new function `insertAttachment` that is utilized
in `ComposeMenu`. It performs the task of uploading the attachment as
well as updating the `ComposeBox` message accordingly.

Related: zulip#4540
AkashDhiman added a commit to AkashDhiman/zulip-mobile that referenced this issue Jun 17, 2021
@AkashDhiman
ComposeMenu: Don't immediately send attachment on upload.
6cc75ca 
On pressing attach file from compose menu, attachment was directly
dispatched to outbox, they should go through compose box so that a user
may add more text if desired.

This commit creates a new function `insertAttachment` that is utilized
in `ComposeMenu`. It performs the task of uploading the attachment as
well as updating the `ComposeBox` message accordingly.

Related: zulip#4540
AkashDhiman added a commit to AkashDhiman/zulip-mobile that referenced this issue Jun 17, 2021
@AkashDhiman
ComposeMenu: Don't immediately send attachment on upload.
4a9da10 
On pressing attach file from compose menu, attachment was directly
dispatched to outbox, they should go through compose box so that
a user may add more text if desired.

This commit creates a new function `insertAttachment` that is
utilized in `ComposeMenu`. It performs the task of uploading the
attachment as well as updating the `ComposeBox` message accordingly.

Fixes part of zulip#4540 because images attached via image picker option
is still behaving as earlier, in the hopes of replacing
`react-native-image-picker` before fixing that.

Fixes-part-of: zulip#4540
AkashDhiman added a commit to AkashDhiman/zulip-mobile that referenced this issue Jun 17, 2021
@AkashDhiman
ComposeMenu: Don't immediately send attachment on upload.
0eb64c1 
On pressing attach file from compose menu, attachment was directly
dispatched to outbox, they should go through compose box so that
a user may add more text if desired.

This commit creates a new function `insertAttachment` that is
utilized in `ComposeMenu`. It performs the task of uploading the
attachment as well as updating the `ComposeBox` message accordingly.

Fixes part of zulip#4540 because behaviour of image picker option is
unchanged.

Fixes-part-of: zulip#4540
AkashDhiman added a commit to AkashDhiman/zulip-mobile that referenced this issue Jun 24, 2021
@AkashDhiman
ComposeMenu: Don't immediately send attachment on upload.
838de08 
On pressing attach file from compose menu, attachment was directly
dispatched to outbox, they should go through compose box so that
a user may add more text if desired.

This commit creates a new function `insertAttachment` that is
utilized in `ComposeMenu`. It performs the task of uploading the
attachment as well as updating the `ComposeBox` message accordingly.

Fixes part of zulip#4540 because behaviour of image picker option is
unchanged.

Fixes-part-of: zulip#4540
gnprice pushed a commit to AkashDhiman/zulip-mobile that referenced this issue Jul 1, 2021
@AkashDhiman @gnprice
ComposeMenu: Don't immediately send attachment on upload.
5cfe98e 
On pressing attach file from compose menu, attachment was directly
dispatched to outbox, they should go through compose box so that
a user may add more text if desired.

This commit creates a new function `insertAttachment` that is
utilized in `ComposeMenu`. It performs the task of uploading the
attachment as well as updating the `ComposeBox` message accordingly.

Fixes part of zulip#4540 because behaviour of image picker option is
unchanged.

Fixes-part-of: zulip#4540
@alya alya mentioned this issue Jul 7, 2021
Closed
@chrisbobbe
Copy link
Contributor

Also related: #2684

@AkashDhiman AkashDhiman mentioned this issue Nov 10, 2021
Closed
3 tasks
@chrisbobbe chrisbobbe mentioned this issue Nov 22, 2021
Closed
@chrisbobbe
Copy link
Contributor

We've had another report of this: https://chat.zulip.org/#narrow/stream/48-mobile/topic/Bug.20reports/near/1292530

Marking as P1.

chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Aug 23, 2022
@chrisbobbe @AkashDhiman
compose: Don't immediately send selected image
0bada06 
Fixes: zulip#4540
Co-authored-by: Akash Dhiman <[email protected]>
@chrisbobbe chrisbobbe mentioned this issue Aug 23, 2022
Merged
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Aug 31, 2022
@chrisbobbe @AkashDhiman
compose: Don't immediately send selected image
3c776ab 
Fixes: zulip#4540
Co-authored-by: Akash Dhiman <[email protected]>
@chrisbobbe chrisbobbe mentioned this issue Jan 6, 2023
Merged
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Jan 11, 2023
@chrisbobbe @AkashDhiman
compose: Don't immediately send selected image
89afcf7 
Fixes: zulip#4540
Co-authored-by: Akash Dhiman <[email protected]>
chrisbobbe added a commit to chrisbobbe/zulip-mobile that referenced this issue Jan 11, 2023
@chrisbobbe @AkashDhiman
compose: Don't immediately send selected image
26c7b41 
Fixes: zulip#4540
Co-authored-by: Akash Dhiman <[email protected]>
This was referenced Jan 17, 2023
Closed
Closed
@gnprice gnprice mentioned this issue Apr 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-compose/send Compose box, autocomplete, camera/upload, outbox, sending P1 high-priority
Projects
None yet
Milestone
No milestone
3 participants
@WesleyAC @chrisbobbe @vaibhavs2