[Android] Downloading from lightbox gives error message, though it works

[gnprice]

This is sort of a remnant of the symptom of #3124, now that that's been fixed by #4089.

Originally reported at #4089 (comment) , on that fix PR just before I merged it.

• Tried downloading an image, for Error: Download manager failed to download from (a user_uploads URL) #2115. Steps: Message list > tap an image to get to lightbox > overflow menu > Download image.

  Result: got this error message:
  
  That is a different message from the status quo! So something changed.

  And, notably, it seems like the download actually worked. There was a notification from Download Manager:
  

  And opening that notification, I get to choose between HTML Viewer and Chrome; and either way, it successfully shows the image. Here's Chrome:
  

  Also the download shows up in my Downloads folder, in the Files app:
  
  (there's two of them there because I tried the download twice.)

For a lot of users, the error message will make the experience basically equivalent to the download having not worked, even though secretly it did. So this would still be quite good to fix.

One small debugging step (originally at #4089 (comment) ):

• I was curious where that error message comes from, with its garbled syntax:

  Download manager download failed, the file does not downloaded to destination.

  Found it with grep -r 'downloaded to d' -- it's in the file node_modules/rn-fetch-blob/android/src/main/java/com/RNFetchBlob/RNFetchBlobReq.java, so from rn-fetch-blob.

[agrawal-d]

Hmm, I'm unable to reproduce this issue. Even during development, I never encountered this. 🤔

[agrawal-d]

Further dscussion here.