lint: Enable always_declare_return_types; fix existing places they're missing #851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the _convertTextTheme signature clearer to express, and also lets us specify the return type of mkAddLabel in a reasonable readable syntax.
This commit covers only where the type is totally boring from the function's definition: it's the thing that the autofix would insert, or else it's void and the autofix should insert void. (But there seems to be a bug where the autofix doesn't work if the answer should be void.)
Otherwise the syntax for a function declaration looks a lot like that for a function call.
Collaborator
|
LGTM, thanks! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the return type is omitted, the syntax for a function declaration looks a lot like that for a function call.
Some of these also get clearer because the type is nontrivial and a typedef for it is helpful for describing another function's signature too.
Prompted by
#813 (comment)
and previously
#790 (comment)
… and previously several other occasions, going back to:
#305 (comment)