Skip to content

Conversation

@Syrineladeb02
Copy link

This pull request addresses issue #616, where the star icon appeared too high relative to the message text in the message list. The issue was resolved by adjusting the position of the star icon so that its "shoulders" align with the x-height of the first line of text, ensuring better visual alignment with the message content.
I added padding to adjust the position of the star icon so that its "shoulders" are aligned with the x-height of the first line of text. This ensures better visual alignment with the message content.
Also, its an update for this pull request #625

before

image

after

2024-05-08 (3)
2024-05-08 (4)

Fixes: #616
@sm-sayedi
@gnprice

@sm-sayedi
Copy link
Collaborator

Thanks for the changes @Syrineladeb02. I suggest you read the commit messages guideline again on how to write commit messages and apply it before this is reviewed by the maintainers.

Also, there is no need to close a PR and open a new one for the same issue. You can fix the existing one by applying the methods mentioned in Fixing commits. 🙂

@Syrineladeb02
Copy link
Author

Thanks for the feedback, @sm-sayedi ! I'll revise the commit message and update the pull request accordingly.

@Syrineladeb02 Syrineladeb02 changed the title Fix star icon position in message list (#616) ui: Adjust star icon position in message list May 13, 2024
@gnprice
Copy link
Member

gnprice commented Jun 11, 2024

@Syrineladeb02 Thanks for the contribution! Do you think you'll come back to this PR and address the feedback above?

@gnprice
Copy link
Member

gnprice commented Jul 22, 2024

Closing this PR, as the issue was resolved in #762. Thanks again @Syrineladeb02 for your work on this.

@gnprice gnprice closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Star icon too high on messages

3 participants