Add a central message store#648

Merged

gnprice merged 22 commits intozulip:mainfrom

gnprice:pr-store-message

Jun 5, 2024

Commits on Jun 5, 2024

msglist test [nfc]: Use isSortedWithoutDuplicates to be a bit more legible
chrisbobbe
committed
message [nfc]: Move message data to a MessageStore class

gnprice
authored and
chrisbobbe
committed
message [nfc]: Remove unnecessary `.toList()`
chrisbobbe
committed
msglist test [nfc]: Fix grouping of "ReactionEvent handling"

gnprice
authored and
chrisbobbe
committed
msglist test [nfc]: Cut "async" from main function

gnprice
authored and
chrisbobbe
committed
msglist [nfc]: Rename MessageListView.maybeAddMessage to handleMessageEvent
chrisbobbe
committed
msglist test: Process MessageEvents through whole store, not just model
chrisbobbe
committed
message: Store all messages centrally

gnprice
and
chrisbobbe
committed
message test [nfc]: Add a MessageListView, optionally

gnprice
authored and
chrisbobbe
committed
msglist test [nfc]: Adapt ReactionEvent tests to refer to message store

gnprice
authored and
chrisbobbe
committed
message test [nfc]: Move ReactionEvent tests from msglist test file

gnprice
authored and
chrisbobbe
committed
message test [nfc]: Move make-ReactionEvent handler to example_data
chrisbobbe
committed
message: Mutate messages for reaction events here, instead of in msglists

gnprice
and
chrisbobbe
committed
msglist [nfc]: s/maybeUpdateMessage/handleUpdateMessageEvent/
chrisbobbe
committed
msglist test: Adapt UpdateMessageEvent edit tests to go through whole store
chrisbobbe
committed
message test [nfc]: Move UpdateMessageEvent edit tests from msglist tests
chrisbobbe
committed
message: Mutate messages for message edits here, instead of in msglists

gnprice
and
chrisbobbe
committed
msglist [nfc]: s/maybeUpdateMessageFlags/handleUpdateMessageFlagsEvent/
chrisbobbe
committed
msglist test: Adapt UpdateMessageFlagsEvent tests to go through whole store
chrisbobbe
committed
message test [nfc]: Move UpdateMessageFlagsEvent tests from msglist tests
chrisbobbe
committed
message: Mutate messages for flags events here, instead of in msglists
chrisbobbe
committed
store [nfc]: Note TODOs to update more data structures on fetching messages

gnprice
authored and
chrisbobbe
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add a central message store#648

Add a central message store#648
gnprice merged 22 commits intozulip:mainfrom
gnprice:pr-store-message

Commits on Jun 5, 2024

msglist test [nfc]: Use isSortedWithoutDuplicates to be a bit more legible

message [nfc]: Move message data to a MessageStore class

message [nfc]: Remove unnecessary `.toList()`

msglist test [nfc]: Fix grouping of "ReactionEvent handling"

msglist test [nfc]: Cut "async" from main function

msglist [nfc]: Rename MessageListView.maybeAddMessage to handleMessageEvent

msglist test: Process MessageEvents through whole store, not just model

message: Store all messages centrally

message test [nfc]: Add a MessageListView, optionally

msglist test [nfc]: Adapt ReactionEvent tests to refer to message store

message test [nfc]: Move ReactionEvent tests from msglist test file

message test [nfc]: Move make-ReactionEvent handler to example_data

message: Mutate messages for reaction events here, instead of in msglists

msglist [nfc]: s/maybeUpdateMessage/handleUpdateMessageEvent/

msglist test: Adapt UpdateMessageEvent edit tests to go through whole store

message test [nfc]: Move UpdateMessageEvent edit tests from msglist tests

message: Mutate messages for message edits here, instead of in msglists

msglist [nfc]: s/maybeUpdateMessageFlags/handleUpdateMessageFlagsEvent/

msglist test: Adapt UpdateMessageFlagsEvent tests to go through whole store

message test [nfc]: Move UpdateMessageFlagsEvent tests from msglist tests

message: Mutate messages for flags events here, instead of in msglists

store [nfc]: Note TODOs to update more data structures on fetching messages

Add a central message store#648gnprice merged 22 commits intozulip:mainzulip/zulip-flutter:mainfrom gnprice:pr-store-messagegnprice/zulip-flutter:pr-store-messageCopy head branch name to clipboard

Commits

Commits on Jun 5, 2024

Add a central message store#648
gnprice merged 22 commits intozulip:mainfrom
gnprice:pr-store-message